text builder: resolve an ordering conflict between two section-number-related tests

[jayaddison]

Feature or Bugfix

• Bugfix

Purpose

• Removes a test suite runtime order conflict between test_build_text.test_secnums and test_build_text.test_nonascii_title_line.

Detail

• The test_nonascii_title_line test needs a two-character text_add_secnumbers configuration to pass successfully. The test_secnums test can interfere with this if it runs first, because it modifies that configuration setting, and by default Sphinx env does not reload configuration values in-process after a build has already taken place.

Relates

• Resolves [tests] ToC: ordering condition involving title generation. #12120.
• Relates to [tracker] [tests] Python test suite reliability: striving for non-flaky, parallelizable, random-orderable tests. #12191.

Edit(s): various attempts to improve the clarity of this pull request's description.

[picnixz]

Hum, why do we have this mypy failure?

[jayaddison]

Hum, why do we have this mypy failure?

That's due to the issue reported in #12864, I think.

[picnixz]

Since I didn't integrate the xdist feature yet, I'm ok with this.

[picnixz]

Thank you Jay!

[jayaddison]

Thanks @picnixz! That also reminds me to re-read your test framework pull requests again soon (I think they'll make more sense to me now with some improved understanding of the codebase).

[picnixz]

That also reminds me to re-read your test framework pull requests again soon

It's not really pressing. It's nice for the CI because we would make it run under a minute but we could hit other issues when used in production. But thank you for the suggestion! I will need to fix the conflicts before you review it again though.