Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(i18n): add pt-BR support #852

Merged
merged 4 commits into from
Oct 19, 2024
Merged

feat(i18n): add pt-BR support #852

merged 4 commits into from
Oct 19, 2024

Conversation

Kyo-70
Copy link
Contributor

@Kyo-70 Kyo-70 commented Oct 18, 2024

Here's my contribution to adding my Brazilian Portuguese language to the program.

@Kyo-70
Create pt-BR support
0de9848 
Here's my contribution to adding my Brazilian Portuguese language to the program.
@Kyo-70 Kyo-70 requested a review from a team as a code owner October 18, 2024 23:34
@Kyo-70 Kyo-70 requested review from Delusoire and removed request for a team October 18, 2024 23:34
@Kyo-70 Kyo-70 changed the title Create pt-BR support feat: pt-BR support Oct 18, 2024
@Kyo-70 Kyo-70 changed the title feat: pt-BR support feat: add pt-BR support Oct 18, 2024
@theRealPadster
Copy link
Member

Thanks for the translation. Before it can be used, it needs to be registered in the locale system. Could you do this step here as well?
https://github.com/spicetify/marketplace/wiki/Localizing-Marketplace#registering-your-language

@theRealPadster theRealPadster changed the title feat: add pt-BR support feat(i18n): add pt-BR support Oct 19, 2024
theRealPadster
theRealPadster requested changes Oct 19, 2024
View reviewed changes
Copy link
Member

@theRealPadster theRealPadster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file also needs a .json extension

@Kyo-70
Rename pt-BR to pt-BR.json
87a16eb 
Update add .json
@Kyo-70
Copy link
Contributor Author

Kyo-70 commented Oct 19, 2024

Thanks for the translation. Before it can be used, it needs to be registered in the locale system. Could you do this step here as well? https://github.com/spicetify/marketplace/wiki/Localizing-Marketplace#registering-your-language

I've just made the change and I hope it's correct.

@rxri rxri mentioned this pull request Oct 19, 2024
Closed
@Kyo-70
Update index.ts
9f36a70 
Now I've done it
@Kyo-70
Copy link
Contributor Author

Kyo-70 commented Oct 19, 2024

Now I've done it - update file index.ts

theRealPadster
theRealPadster requested changes Oct 19, 2024
View reviewed changes
src/resources/locales/index.ts Outdated Show resolved Hide resolved
@Kyo-70
Update index.ts
01a2e66 
Ok. done successfully. didn't know I needed it. hope it works now.
@Kyo-70
Copy link
Contributor Author

Kyo-70 commented Oct 19, 2024

Successfully added the order correction update to the Index file.

theRealPadster
theRealPadster approved these changes Oct 19, 2024
View reviewed changes
Copy link
Member

@theRealPadster theRealPadster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed the checks finally, thank you!

@theRealPadster theRealPadster merged commit 8fb3193 into spicetify:main Oct 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theRealPadster theRealPadster theRealPadster approved these changes

@Delusoire Delusoire Awaiting requested review from Delusoire Delusoire is a code owner automatically assigned from spicetify/marketplace

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kyo-70 @theRealPadster