Skip to content
This repository has been archived by the owner on Mar 22, 2024. It is now read-only.

option to configure agent sds #479

Merged
merged 13 commits into from
Sep 11, 2023
Merged

option to configure agent sds #479

merged 13 commits into from
Sep 11, 2023

Conversation

grameshtwilio
Copy link
Contributor

@grameshtwilio grameshtwilio commented Sep 7, 2023 •
edited
Loading

Not sure if this is the preferred way. Could also populate the values file with defaults from https://github.com/spiffe/spire/blob/main/doc/spire_agent.md#sds-configuration

@faisal-memon
Copy link
Contributor

Hi @grameshtwilio thanks for the submission. Populating the values with defaults is preferred, but we understand people are busy. If you are able to do that, then great. If not we can take the changes as is and fill them in later.

@faisal-memon
Copy link
Contributor

Also note we have a major docs refactor we are hoping to merge next. There might be some merge conflicts here when you update after than one is merged.

@grameshtwilio
Copy link
Contributor Author

Also note we have a major docs refactor we are hoping to merge next. There might be some merge conflicts here when you update after than one is merged.

I'll keep an eye on it and rebase/alter this PR to incorporate the new format.

@faisal-memon faisal-memon added this to the 0.13.0 milestone Sep 8, 2023
faisal-memon
faisal-memon approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@faisal-memon faisal-memon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grameshtwilio

kfox1111
kfox1111 reviewed Sep 8, 2023
View reviewed changes
Copy link
Contributor

@kfox1111 kfox1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Some naming issues inline.

charts/spire/README.md Outdated Show resolved Hide resolved
marcofranssen
marcofranssen suggested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@marcofranssen marcofranssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion on making the sds config really optional.

@grameshtwilio
option to add sds config to the agent
80a98da 
Signed-off-by: grameshtwilio <gramesh@twilio.com>
@grameshtwilio
indent
85ff545 
Signed-off-by: grameshtwilio <gramesh@twilio.com>
@grameshtwilio
add docs
0090335 
Signed-off-by: grameshtwilio <gramesh@twilio.com>
@grameshtwilio
populate sds config with default values
b3b85be 
Signed-off-by: grameshtwilio <gramesh@twilio.com>
@grameshtwilio
populate sds config with default values
168d0d8 
Signed-off-by: grameshtwilio <gramesh@twilio.com>
@grameshtwilio
fix disable_spiffe_cert_validation
799a118 
Signed-off-by: grameshtwilio <gramesh@twilio.com>
@grameshtwilio
rebase and adopt new comment format
c3f1881 
Signed-off-by: grameshtwilio <gramesh@twilio.com>
@grameshtwilio
camelCase path variables
92008b9 
Signed-off-by: grameshtwilio <gramesh@twilio.com>
@grameshtwilio
update docs
a108f28 
Signed-off-by: grameshtwilio <gramesh@twilio.com>
@grameshtwilio
make SDS config optional
6e1d59a 
Signed-off-by: grameshtwilio <gramesh@twilio.com>
@grameshtwilio
make SDS config optional
bca7f32 
Signed-off-by: grameshtwilio <gramesh@twilio.com>
@grameshtwilio @marcofranssen
Update charts/spire/charts/spire-agent/values.yaml
a8c4846 
Co-authored-by: Marco Franssen <marco.franssen@gmail.com>
Signed-off-by: grameshtwilio <83727765+grameshtwilio@users.noreply.github.com>
@grameshtwilio
generate docs
0475967 
Signed-off-by: grameshtwilio <gramesh@twilio.com>
marcofranssen
marcofranssen approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@marcofranssen marcofranssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@marcofranssen marcofranssen enabled auto-merge (squash) September 11, 2023 11:21
@marcofranssen marcofranssen merged commit 9ad2ed5 into spiffe:main Sep 11, 2023
marcofranssen added a commit that referenced this pull request Sep 15, 2023
@marcofranssen
Bump spire Helm Chart version from 0.12.0 to 0.13.0
2a83dbe 
* 38f0af4 Add support for Vault UpstreamAuthority plugin - K8s Auth (#415)
* 1aac2d4 Bump docker/login-action from 2 to 3
* 1f90867 Allow configuration of priorityClassName on spire-server statefulset (#480)
* 9ad2ed5 option to configure agent sds (#479)
* 693ce08 Remove ## values section from chart readms
* 65d5695 Migrate to readme-generator for helm maintained by bitnami (#431)
* dcc60a2 fix(charts/spire/spire-agent): podmonitor templating (#478)
* 48adb88 Bump actions/checkout from 3.6.0 to 4.0.0
* d1f52d6 Bump sigstore/cosign-installer from 3.1.1 to 3.1.2 (#473)
* 5273f4e Switch mysql and postgresql tests to HA Production configs (#471)
* e81a59a ingress-nginx production tests and spiffe-oidc-discovery-provider example (#136)
* b05175e Bump actions/checkout from 3.5.3 to 3.6.0
* 51cba5b Add customPlugins and unsupportedBuiltInPlugins sections to spire-server (#198)
* f4ee2c2 Bump github.com/onsi/ginkgo/v2 from 2.11.0 to 2.12.0 in /tests (#468)
* c817dd2 support datastore password secret created by external resources (#464)
* 71ac5af Split steps in check-versions wf for easier debugging (#467)
* d91403a Scan for updates to new images (#466)
* 7a5456e Bump helm.sh/helm/v3 from 3.11.3 to 3.12.3 in /tests (#462)
* cbe0001 Federation test (#423)

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
@marcofranssen marcofranssen mentioned this pull request Sep 15, 2023
Merged
marcofranssen added a commit that referenced this pull request Sep 15, 2023
@marcofranssen
Bump spire Helm Chart version from 0.12.0 to 0.13.0
4cd53fa 
* 38f0af4 Add support for Vault UpstreamAuthority plugin - K8s Auth (#415)
* 1aac2d4 Bump docker/login-action from 2 to 3
* 1f90867 Allow configuration of priorityClassName on spire-server statefulset (#480)
* 9ad2ed5 option to configure agent sds (#479)
* 693ce08 Remove ## values section from chart readms
* 65d5695 Migrate to readme-generator for helm maintained by bitnami (#431)
* dcc60a2 fix(charts/spire/spire-agent): podmonitor templating (#478)
* 48adb88 Bump actions/checkout from 3.6.0 to 4.0.0
* d1f52d6 Bump sigstore/cosign-installer from 3.1.1 to 3.1.2 (#473)
* 5273f4e Switch mysql and postgresql tests to HA Production configs (#471)
* e81a59a ingress-nginx production tests and spiffe-oidc-discovery-provider example (#136)
* b05175e Bump actions/checkout from 3.5.3 to 3.6.0
* 51cba5b Add customPlugins and unsupportedBuiltInPlugins sections to spire-server (#198)
* f4ee2c2 Bump github.com/onsi/ginkgo/v2 from 2.11.0 to 2.12.0 in /tests (#468)
* c817dd2 support datastore password secret created by external resources (#464)
* 71ac5af Split steps in check-versions wf for easier debugging (#467)
* d91403a Scan for updates to new images (#466)
* 7a5456e Bump helm.sh/helm/v3 from 3.11.3 to 3.12.3 in /tests (#462)
* cbe0001 Federation test (#423)

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
marcofranssen added a commit that referenced this pull request Sep 15, 2023
@marcofranssen
Bump spire Helm Chart version from 0.12.0 to 0.13.0
ae84d8b 
* 38f0af4 Add support for Vault UpstreamAuthority plugin - K8s Auth (#415)
* 1aac2d4 Bump docker/login-action from 2 to 3
* 1f90867 Allow configuration of priorityClassName on spire-server statefulset (#480)
* 9ad2ed5 option to configure agent sds (#479)
* 693ce08 Remove ## values section from chart readms
* 65d5695 Migrate to readme-generator for helm maintained by bitnami (#431)
* dcc60a2 fix(charts/spire/spire-agent): podmonitor templating (#478)
* 48adb88 Bump actions/checkout from 3.6.0 to 4.0.0
* d1f52d6 Bump sigstore/cosign-installer from 3.1.1 to 3.1.2 (#473)
* 5273f4e Switch mysql and postgresql tests to HA Production configs (#471)
* e81a59a ingress-nginx production tests and spiffe-oidc-discovery-provider example (#136)
* b05175e Bump actions/checkout from 3.5.3 to 3.6.0
* 51cba5b Add customPlugins and unsupportedBuiltInPlugins sections to spire-server (#198)
* f4ee2c2 Bump github.com/onsi/ginkgo/v2 from 2.11.0 to 2.12.0 in /tests (#468)
* c817dd2 support datastore password secret created by external resources (#464)
* 71ac5af Split steps in check-versions wf for easier debugging (#467)
* d91403a Scan for updates to new images (#466)
* 7a5456e Bump helm.sh/helm/v3 from 3.11.3 to 3.12.3 in /tests (#462)
* cbe0001 Federation test (#423)

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
marcofranssen added a commit that referenced this pull request Sep 15, 2023
@marcofranssen
Bump spire Helm Chart version from 0.12.0 to 0.13.0
66e8708 
* 38f0af4 Add support for Vault UpstreamAuthority plugin - K8s Auth (#415)
* 1aac2d4 Bump docker/login-action from 2 to 3
* 1f90867 Allow configuration of priorityClassName on spire-server statefulset (#480)
* 9ad2ed5 option to configure agent sds (#479)
* 693ce08 Remove ## values section from chart readms
* 65d5695 Migrate to readme-generator for helm maintained by bitnami (#431)
* dcc60a2 fix(charts/spire/spire-agent): podmonitor templating (#478)
* 48adb88 Bump actions/checkout from 3.6.0 to 4.0.0
* d1f52d6 Bump sigstore/cosign-installer from 3.1.1 to 3.1.2 (#473)
* 5273f4e Switch mysql and postgresql tests to HA Production configs (#471)
* e81a59a ingress-nginx production tests and spiffe-oidc-discovery-provider example (#136)
* b05175e Bump actions/checkout from 3.5.3 to 3.6.0
* 51cba5b Add customPlugins and unsupportedBuiltInPlugins sections to spire-server (#198)
* f4ee2c2 Bump github.com/onsi/ginkgo/v2 from 2.11.0 to 2.12.0 in /tests (#468)
* c817dd2 support datastore password secret created by external resources (#464)
* 71ac5af Split steps in check-versions wf for easier debugging (#467)
* d91403a Scan for updates to new images (#466)
* 7a5456e Bump helm.sh/helm/v3 from 3.11.3 to 3.12.3 in /tests (#462)
* cbe0001 Federation test (#423)

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kfox1111 kfox1111 kfox1111 left review comments

@faisal-memon faisal-memon faisal-memon approved these changes

@marcofranssen marcofranssen marcofranssen approved these changes

@developer-guy developer-guy Awaiting requested review from developer-guy

@dfeldman dfeldman Awaiting requested review from dfeldman

@mrsabath mrsabath Awaiting requested review from mrsabath

@edwbuck edwbuck Awaiting requested review from edwbuck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@grameshtwilio @faisal-memon @marcofranssen @kfox1111