Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete useless UserSessionRepository #7

Merged
merged 5 commits into from
May 21, 2024

Conversation

MykytaPimonovTD
Copy link
Contributor

@MykytaPimonovTD MykytaPimonovTD commented May 20, 2024

This changeset replaces UserSessionRepository with default add() method in BoundedContextBuilder since the entity does not require specific routing. UserSessionRepository is deleted.

It is also explicitly stated in the mentions configuration that the Gradle task of compiling the Kotlin should be only after Protobuf file generation and rejections creation is complete, to avoid build errors.

@MykytaPimonovTD MykytaPimonovTD self-assigned this May 20, 2024
Copy link
Contributor

@armiol armiol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MykytaPimonovTD please see my comments.

mentions/build.gradle.kts Show resolved Hide resolved
Copy link
Contributor

@armiol armiol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment.

@MykytaPimonovTD MykytaPimonovTD merged commit 7121c68 into master May 21, 2024
1 check passed
@MykytaPimonovTD MykytaPimonovTD deleted the delete-unused-sessions-repository branch May 21, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants