Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(*): bump controller-gen to v0.16.3; config updates #225

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

vdice
Copy link
Collaborator

@vdice vdice commented Sep 26, 2024

Describe your changes

  • Bumps controller-tools to the latest v0.16.3 release

  • Includes controller-gen updates to a few files in config

    • These seem to be fairly innocuous, but could use a close look
    • Includes some description re-formatting and re-wording and RBAC consolidation

Note: I'm not yet able to fully test via the make build deploy flow as RBAC issues remain.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • I tested the changes with the following distributions:
    • Kind
    • MiniKube
    • MicroK8s
    • Rancher RKE2
    • Azure AKS
    • GCP GKE (Ubuntu nodes)
    • AWS EKS (AmazonLinux2 nodes)
    • AWS EKS (Ubuntu nodes)
    • Digital Ocean Kubernetes

@voigt
Copy link
Contributor

voigt commented Oct 27, 2024

@vdice would you like to fix the merge conflict?
Apart from that PR LGTM.

Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
@vdice
Copy link
Collaborator Author

vdice commented Oct 28, 2024

Rebased; thanks @voigt!

@vdice vdice requested a review from voigt October 28, 2024 18:06
@voigt voigt merged commit 51e5266 into spinkube:main Oct 29, 2024
8 checks passed
@vdice vdice deleted the ref/bump-controller-gen branch October 29, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants