helm: fix generated chart RBAC #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After we updated the operator RBAC to include Events, we never updated the checked in version of the chart to reflect that. This doesn't effect releases, as CI regenerates the helm chart, but does impact people who checkout the repository and use the local helm chart. Signed-off-by: Danielle Lancashire <dani@builds.terrible.systems>
endocrimes
requested review from
calebschoepp,
bacongobbler,
michelleN and
rajatjindal
as code owners
|
I thought at some stage we had a CI step to verify there is no delta between generated helm chart and the one checked-in into the repo |
I think we talked about it but never actually did it 😅 |
michelleN
approved these changes
Sep 12, 2024
calebschoepp
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we updated the operator RBAC to include Events, we never updated the checked in version of the chart to reflect that.
This doesn't effect releases, as CI regenerates the helm chart, but does impact people who checkout the repository and use the local helm chart.