Support runtime config in the spintainer executor #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caleb Schoepp <caleb.schoepp@fermyon.com>
calebschoepp
requested review from
endocrimes,
bacongobbler,
michelleN and
rajatjindal
as code owners
|
Could you make sure this is covered by tests at the same time? (I'm a bit worried about spintainer feature drift because I assume it'll be used much less frequently, covering in tests for the big things should help us there 😅) |
calebschoepp
force-pushed
the
runtime-config
branch
from
fccfbd2
to
c3b4003
Compare
|
@endocrimes I've added some tests. |
calebschoepp
force-pushed
the
runtime-config
branch
from
c3b4003
to
d7aa259
Compare
endocrimes
requested changes
Sep 24, 2024
…edis as a the kv backend Signed-off-by: Caleb Schoepp <caleb.schoepp@fermyon.com>
calebschoepp
force-pushed
the
runtime-config
branch
from
d7aa259
to
8c4c9da
Compare
|
Nice catch @endocrimes, I made those fixes to the spintainer e2e too and overall this shaved 4 minutes off the e2e tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #319.
I tested locally to make sure that this works both when runtime config is specified and when it isn't.