Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deserialize all trigger metadata as strings #41

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

kate-goldenring
Copy link
Contributor

When updating to latest spin dependencies, we changed trigger metadata to no longer be strings: #40

Right now, the trigger fails to run with the errors:

Error: metadata error: invalid metadata value for "mqtt": Error("invalid type: string \"30\", expected u64", line: 0, column: 0)

And

Error: json error: invalid type: string "1", expected i32

Caused by:
    invalid type: string "1", expected i32

This PR resolves the error by making all deserialized metadata strings.

Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
@kate-goldenring
Copy link
Contributor Author

This provides motivation to add more tests to the repo

Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Thanks for fixing this.

@karthik2804 karthik2804 merged commit 083959e into spinkube:main Oct 9, 2024
7 checks passed
@kate-goldenring kate-goldenring deleted the fix-metadata-parsing branch October 9, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants