This repository was archived by the owner on Dec 20, 2025. It is now read-only.
fix(titus): Set default disruption budget based on job type#5250
Closed
aravindmd wants to merge 1 commit intospinnaker:masterfrom
Closed
fix(titus): Set default disruption budget based on job type#5250aravindmd wants to merge 1 commit intospinnaker:masterfrom
aravindmd wants to merge 1 commit intospinnaker:masterfrom
Conversation
Contributor
Author
|
Confirmed with Titus , this should work fine. |
robzienert
approved these changes
Feb 16, 2021
Member
|
Would do well to have a test for this. |
Contributor
Author
Agree , will look at adding one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Titus batch jobs submitted through a Run Job pipeline stage defaults to a global default policy, This policy is well suited for services, but inappropriate for batch jobs as it allows to kill running batch jobs, Setting it to
self-managedis a better option since this has the setting on Titus to not disrupt the jobs.