fix(ldap): Return a new ExternalUser from multiLoadRoles in LDAP (#260)

spinnaker · Aug 29, 2018 · 2c8212d · 2c8212d
1 parent 397706a
commit 2c8212d
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/fiat-ldap/src/main/java/com/netflix/spinnaker/fiat/roles/ldap/LdapUserRolesProvider.java b/fiat-ldap/src/main/java/com/netflix/spinnaker/fiat/roles/ldap/LdapUserRolesProvider.java
@@ -101,7 +101,7 @@ public Map<String, Collection<Role>> multiLoadRoles(Collection<ExternalUser> use
 
     // ExternalUser is used here as a simple data type to hold the username/roles combination.
     return users.stream()
-        .map(u -> u.setExternalRoles(loadRoles(u)))
+        .map(u -> new ExternalUser().setId(u.getId()).setExternalRoles(loadRoles(u)))
         .collect(Collectors.toMap(ExternalUser::getId, ExternalUser::getExternalRoles));
   }