-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cdevents-webhooks) : Adding support for Artifact Constraints and Parameters using CDEvents data #1732
Conversation
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
Couple of concerns:
|
There is an existing test for this endpoint to test with SUCCESS and BAD_REQUEST validations. The headers are mandatory when sending CloudEvent as per required-attributes, but I can also get these from the |
…to cdevents_artifacts_params
…to cdevents_artifacts_params
gate-core/src/main/java/com/netflix/spinnaker/gate/services/internal/EchoService.java
Show resolved
Hide resolved
@jasonmcintosh Can you please merge this if there are no other comments. Thank you. |
This PR has the changes to pass the CDEvents data to the Echo service, to validate the CDEvents data and run the pipeline executions with Artifact Constraints and Parameters.
Dependent PR : spinnaker/echo#1357