Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bakery): change exception handling in MonitorBakeTask to use Spinnaker*Exception instead of RetrofitError now that https://github.com/spinnaker/orca/pull/4529 has added SpinnakerRetrofitErrorHandler to BakerySelector #4576

Merged
merged 1 commit into from
Oct 27, 2023
Merged

fix(bakery): change exception handling in MonitorBakeTask to use Spinnaker*Exception instead of RetrofitError now that https://github.com/spinnaker/orca/pull/4529 has added SpinnakerRetrofitErrorHandler to BakerySelector #4576

merged 1 commit into from
Oct 27, 2023

Conversation

Pranav-b-7
Copy link
Contributor

bug fix:

@Pranav-b-7
fix(bakery): change exception handling in MonitorBakeTask to use Spin…
6cf9923 
…naker*Exception instead of RetrofitError now that spinnaker#4529 has added SpinnakerRetrofitErrorHandler to BakerySelector
@dbyron-sf dbyron-sf added the ready to merge Approved and ready for merge label Oct 27, 2023
@mergify mergify bot added the auto merged Merged automatically by a bot label Oct 27, 2023
@mergify mergify bot merged commit b1071bd into spinnaker:master Oct 27, 2023
4 checks passed
@Pranav-b-7 Pranav-b-7 deleted the eliminate-RetrofitError branch October 30, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbyron-sf dbyron-sf dbyron-sf approved these changes

Assignees
No one assigned
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for merge target-release/1.33
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pranav-b-7 @dbyron-sf @spinnakerbot