-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid using GLib internally #116
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only functions that need default linkage are those called with load-extension. The new macro GIG_API explicitly marks a function as visibile.
Replace with strvlen
SCM doesn't compare using greater-than '<'. Nor is (SCM)0 valid.
2ce99bf
to
11d4c70
Compare
Bleh, I restarted with a new branch #dev-avoid-glib2 because this one was too messy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is phase one of #96 . It reduces the internal dependence of guile-gi on GLib. Of course, some use of GLib is necessary specifically when marshaling and converting to/from arguments that have GLib types.
The simplistic replacement to the GLib hash table is slower, and much of the functionality in logging has been culled, for now.
But theoretically, nothing else should change as a result of this patchset.