Skip to content

Commit

Permalink
Remove spfs-join from process tree
Browse files Browse the repository at this point in the history
Our users reported some unexpected behaviour, like spfs-join capturing
ctrl-c and breaking interactions with launched processes.

Signed-off-by: Ryan Bottriell <rbottriell@ilm.com>
  • Loading branch information
rydrman committed Dec 13, 2023
1 parent 79ad8fe commit 53d35df
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions crates/spfs-cli/cmd-join/src/cmd_join.rs
Original file line number Diff line number Diff line change
Expand Up @@ -129,12 +129,9 @@ impl CmdJoin {
spfs::build_interactive_shell_command(rt, None)?
}
};
let mut proc = cmd.into_std();
tracing::debug!("{:?}", proc);
Ok(proc
.status()
.map_err(|err| Error::process_spawn_error("exec_runtime_command", err, None))?
.code()
.unwrap_or(1))
tracing::debug!("{cmd:?}");
cmd.exec()
.map(|_| 0)
.wrap_err("Failed to execute runtime command")
}
}

0 comments on commit 53d35df

Please sign in to comment.