-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix poor performance of to_tracking_manifest
This method had something like O(n^3) complexity because it would for every tree in a manifest iterate over every tree in a manifest and calculate the digest for every tree in the manifest (modulo short circuiting). `Manifest::get_tree` is culprit and an alternative technique of caching the lookup of digest to tree was added. Both uses of this method have been updated but this method was left in place with a new warning. It would be cheaper to call `get_tree` in a contrived case where the cache is only accessed once and not reused for multiple lookups. Fixes #1043. Signed-off-by: J Robert Ray <jrray@imageworks.com>
- Loading branch information
J Robert Ray
committed
Jun 13, 2024
1 parent
9892a89
commit e6fb537
Showing
4 changed files
with
46 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters