Use flatbuffers in grpc instead of protobuf fields #1010
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will still allow the server to accept old-style messages but always responds with flatbuffers. I'm mainly just keeping the other code around so that I can make a build internally to handle the transition - I thought about adding additional fields/etc to support a transition more easily but it doesn't seem worth the effort given that only we are using the server so far. I'm open to ideas if it seems like there's an desire and easy way to do this, but otherwise I'll circle back later and remove the rest of the old format.