Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use flatbuffers in grpc instead of protobuf fields #1010

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

rydrman
Copy link
Collaborator

@rydrman rydrman commented Mar 15, 2024

This will still allow the server to accept old-style messages but always responds with flatbuffers. I'm mainly just keeping the other code around so that I can make a build internally to handle the transition - I thought about adding additional fields/etc to support a transition more easily but it doesn't seem worth the effort given that only we are using the server so far. I'm open to ideas if it seems like there's an desire and easy way to do this, but otherwise I'll circle back later and remove the rest of the old format.

@rydrman rydrman requested review from jrray and dcookspi March 15, 2024 04:22
@rydrman rydrman self-assigned this Mar 15, 2024
Copy link
Collaborator

@jrray jrray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still true we're not using the server stuff, I'll go with your gut on this.

@rydrman rydrman force-pushed the flatbuffer-via-grpc branch 2 times, most recently from 9cd9f93 to c9984b4 Compare March 15, 2024 04:33
Signed-off-by: Ryan Bottriell <ryan@bottriell.ca>
@rydrman rydrman merged commit c7bac69 into main Mar 15, 2024
7 checks passed
@rydrman rydrman deleted the flatbuffer-via-grpc branch March 15, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants