Add test for graph::Manifest conversion from tracking::Manifest #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… relocates Entry tests that were in the graph::Manifest test file. Signed-off-by: David Gilligan-Cook <dcook@imageworks.com>
rydrman
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test for graph::Manifest conversion from tracking::Manifest to make sure the converted manifest is not missing any entries, by checking it is identical to the original manifest when converted back.
We encountered a situation with our internal, pre-flatbuffers, build where this was not the case. That bug was patched internally, and we confirmed the problem does not exist in post-flatbuffers changes. But want to add the test that detects it to the test suite.
This also relocates the entry related tests that were in the graph::Manifest test file to the
entry_test.rsfile with the other entry related tests.