Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -v flags to spk-convert-pip and update spk convert to pass verbosity through #1019

Merged
merged 2 commits into from
May 15, 2024

Conversation

dcookspi
Copy link
Collaborator

@dcookspi dcookspi commented May 3, 2024

This adds -v/--verbose option flag to the spk-convert-pip script to change the logging level. It updates spk convert ... command to pass the verbosity level through to the underlying spk-convert-... command, and adds debug logging to show the underlying command.

This allows -v to be used to turn on/up debugging messages for both the spk convert ... command and the underlying script with one option, or turn on debugging for just the underlying script.

For example:

# increase the verbosity for both
> spk convert pip -v -- somepackage --python-version 3.9 --python-abi cp39
> spk convert pip -vv -- somepackage --python-version 3.9 --python-abi cp39

# increase the verbosity for the underlying script only
> spk convert pip -- somepackage --python-version 3.9 --python-abi cp39 -v
> spk convert pip -- somepackage --python-version 3.9 --python-abi cp39 -vv

@dcookspi dcookspi added enhancement New feature or request SPI AOI Area of interest for SPI SPI-0.41 labels May 3, 2024
@dcookspi dcookspi self-assigned this May 3, 2024
@dcookspi dcookspi requested review from rydrman and jrray May 3, 2024 22:11
packages/spk-convert-pip/spk-convert-pip Outdated Show resolved Hide resolved
@dcookspi dcookspi force-pushed the spk-convert-pip-add-verbose-flags branch from 47e55fe to a057b65 Compare May 15, 2024 18:56
Base automatically changed from spk-convert-pip-add-no-publish to main May 15, 2024 19:12
… verbosity level on

Signed-off-by: David Gilligan-Cook <dcook@imageworks.com>
Signed-off-by: David Gilligan-Cook <dcook@imageworks.com>
@dcookspi dcookspi force-pushed the spk-convert-pip-add-verbose-flags branch from a057b65 to 0bcb906 Compare May 15, 2024 19:14
@dcookspi dcookspi merged commit 087af1f into main May 15, 2024
7 checks passed
@dcookspi dcookspi deleted the spk-convert-pip-add-verbose-flags branch May 15, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request SPI AOI Area of interest for SPI SPI-0.41
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants