Bugfix: implements counting hardlinks for directories in spfs' fuse #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Gilligan-Cook <dcook@imageworks.com>
rydrman
approved these changes
May 9, 2024
jrray
reviewed
May 9, 2024
crates/spfs-vfs/src/fuse.rs
Outdated
Comment on lines
173
to
174
| // Directory has 2 hardlinks for . and .. plus one for | ||
| // each subdirectory. Symlinks do not count. |
There was a problem hiding this comment.
. and .. would refer to different inodes, so this explanation for why we add 2 here isn't quite right. But I think the idea here is that an empty directory has a count of 2 because there's the entry for it in its parent, and then there's the . entry inside it.
As in stat ../dirname and stat . would show the same inode.
There was a problem hiding this comment.
I've updated the comment to try to make it clearer.
Signed-off-by: David Gilligan-Cook <dcook@imageworks.com>
jrray
approved these changes
May 15, 2024
dcookspi
deleted the
1020-bug-spfs-fuse-doesnt-count-hardlinksnlink-correctly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements counting hardlinks for directories in spfs' fuse. The makes the
nlinkvalues directories valid for external processes that access a spfs fuse-backed filesystem, e.g. perl's File::Find module.