Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MS_SLAVE instead of MS_PRIVATE when starting a new namespace #1025

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Use MS_SLAVE instead of MS_PRIVATE when starting a new namespace #1025

merged 2 commits into from
Jun 4, 2024

Conversation

rydrman
Copy link
Collaborator

@rydrman rydrman commented May 15, 2024

This is addressing 2 issues:

  1. We had some complaints that USB media was not visible from spfs shells once inserted, which this solves by allowing the new mount under /media to propagate into the namespace
  2. We had issues on el9.3 (alma) where autofs would unmount an expired mount point which would make it go away in the namespace, but then when it got remounted it would never reappear in the spfs shell. We're not sure why this was working in CentOS 7, but in any case this change more accurately describes the behaviour that we want to achieve.

@rydrman
Use SLAVE mount flags in spfs
018f18a 
Signed-off-by: Ryan Bottriell <rbottriell@ilm.com>
@rydrman rydrman added bug Something isn't working ILM in-use Deployed and in-use at ILM labels May 15, 2024
@rydrman rydrman requested a review from jrray May 15, 2024 22:01
@rydrman rydrman self-assigned this May 15, 2024
jrray
jrray approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@jrray jrray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but CI is failing.

@rydrman
Ignore ENOENT errors when checking if paths are mounted
179c9ef 
It's safe to say that paths that do not exist are not mounted for all of
the purposes in the spfs setup logic

Signed-off-by: Ryan Bottriell <ryan@bottriell.ca>
@rydrman
Copy link
Collaborator Author

rydrman commented May 16, 2024

Thanks, seems like a case where /spfs does not exist yet and so the is_mounted query errors out. I've added code to handle this ENOENT case gracefully

@rydrman
Copy link
Collaborator Author

rydrman commented May 16, 2024

I'm just going to give this one a couple of days to see if any bad feedback comes in before merging

@rydrman
Copy link
Collaborator Author

rydrman commented Jun 4, 2024

Still no issues for us so I'm going to merge this

@rydrman rydrman merged commit ee3e287 into main Jun 4, 2024
7 checks passed
@rydrman rydrman deleted the better-mount-management branch June 4, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrray jrray jrray approved these changes

Assignees

@rydrman rydrman

Labels
bug Something isn't working ILM in-use Deployed and in-use at ILM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rydrman @jrray