Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generated code from source control #1028

Merged
merged 1 commit into from
May 18, 2024
Merged

Remove generated code from source control #1028

merged 1 commit into from
May 18, 2024

Conversation

jrray
Copy link
Collaborator

@jrray jrray commented May 17, 2024

It's not clear that this file was intentionally added to source control since it appears in a seemingly unrelated commit.

Use recommended pattern of putting generated code into $OUT_DIR, as mentioned here: https://doc.rust-lang.org/cargo/reference/build-script-examples.html

It's not clear that this file was intentionally added to source control
since it appears in a seemingly unrelated commit.

Use recommended pattern of putting generated code into `$OUT_DIR`, as
mentioned here: https://doc.rust-lang.org/cargo/reference/build-script-examples.html

Signed-off-by: J Robert Ray <jrray@jrray.org>
@jrray jrray added the maintenance Cleanup, upgrades, etc label May 17, 2024
@jrray jrray self-assigned this May 17, 2024
@jrray jrray requested a review from rydrman May 17, 2024 00:19
Copy link
Collaborator

@rydrman rydrman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to say, maybe it was me debugging something...

@jrray jrray merged commit 5b453f8 into main May 18, 2024
7 checks passed
@jrray jrray deleted the rm-generated-code branch May 18, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Cleanup, upgrades, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants