Rework storage tests to test both encoding formats #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix tests failing if the default encoding is switched to legacy in the code; make the tests not rely on what the coded default is. Signed-off-by: J Robert Ray <jrray@jrray.org>
These other tests are subject to spurious failures if run concurrently with the tests that change the encoding format. Now they can test for correct behavior for both digest strategies. Signed-off-by: J Robert Ray <jrray@jrray.org>
Related to concurrent tests and config changing. Signed-off-by: J Robert Ray <jrray@jrray.org>
|
I'm encountering a series of spurious test failures in our internal CI, likely only happening there because we have the defaults flipped to legacy, hence the series of followup commits. I'll keep iterating until they go away, but this isn't a great situation and I can't be sure they're all gone once I get the CI to pass [once]. |
|
At this point it passed CI internally and survived a couple retry runs. Edit: some more spurious errors showed up after another CI run. |
Signed-off-by: J Robert Ray <jrray@jrray.org>
Signed-off-by: J Robert Ray <jrray@jrray.org>
|
Better results after the additional changes, however we might as well leave this open for a bit to get more CI runs under our belt. |
rydrman
approved these changes
Jun 18, 2024
|
We made it through a good number of successful CI runs now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tests failing if the default encoding is switched to legacy in the code; make the tests not rely on what the coded default is.