-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework storage tests to test both encoding formats #1052
Conversation
Fix tests failing if the default encoding is switched to legacy in the code; make the tests not rely on what the coded default is. Signed-off-by: J Robert Ray <jrray@jrray.org>
These other tests are subject to spurious failures if run concurrently with the tests that change the encoding format. Now they can test for correct behavior for both digest strategies. Signed-off-by: J Robert Ray <jrray@jrray.org>
Related to concurrent tests and config changing. Signed-off-by: J Robert Ray <jrray@jrray.org>
I'm encountering a series of spurious test failures in our internal CI, likely only happening there because we have the defaults flipped to legacy, hence the series of followup commits. I'll keep iterating until they go away, but this isn't a great situation and I can't be sure they're all gone once I get the CI to pass [once]. |
At this point it passed CI internally and survived a couple retry runs. Edit: some more spurious errors showed up after another CI run. |
Signed-off-by: J Robert Ray <jrray@jrray.org>
Signed-off-by: J Robert Ray <jrray@jrray.org>
Better results after the additional changes, however we might as well leave this open for a bit to get more CI runs under our belt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also fine to merge this and iterate as needed... the changes all look reasonable
We made it through a good number of successful CI runs now. |
Fix tests failing if the default encoding is switched to legacy in the code; make the tests not rely on what the coded default is.