Change license metadata semantics #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrray
reviewed
Jul 16, 2024
| impl Meta { | ||
| pub fn is_default(&self) -> bool { | ||
| self == &Self::default() | ||
| } | ||
| fn default_license() -> String { | ||
| "Unlicensed".into() |
There was a problem hiding this comment.
So will packages that contain this "Unlicensed" license now be considered invalid to read that package? Or does this change only affect builds of packages?
There was a problem hiding this comment.
The validation only runs at build time so existing published packages should be okay
Signed-off-by: Ryan Bottriell <ryan@bottriell.ca>
Signed-off-by: Ryan Bottriell <ryan@bottriell.ca>
rydrman
force-pushed
the
984-license-metadata
branch
from
f5badbd
to
4a30858
Compare
jrray
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the license field to be an
Option<String>as desired.Also adds a validation rule for checking if it's a valid SPDX license identifier, which becomes a default.
closes #984
FYI @dcookspi