Handle when multiple packages embed the same package #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The solver was panicking with "state not found" in the case where it encounters a package that embeds some other package, but that other package has already been embedded by some third package. It wanted to "eject" the real package (again) but no "real" package was in the solution at that point. Now it checks that the package it wants to "eject" is a not an embedded package. This situation was given its own `IncompatibleReason` so the solver output will detail the packages involved. Signed-off-by: J Robert Ray <jrray@jrray.org>
rydrman
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solver was panicking with "state not found" in the case where it encounters a package that embeds some other package, but that other package has already been embedded by some third package. It wanted to "eject" the real package (again) but no "real" package was in the solution at that point.
Now it checks that the package it wants to "eject" is a not an embedded package. This situation was given its own
IncompatibleReasonso the solver output will detail the packages involved.