Preserve install environment #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both recipes and packages have the `install.environment` property, so refactor `runtime_environment()` out of the `Package` trait into its own trait, then require both `Recipe` and `Package` implement it. Signed-off-by: J Robert Ray <jrray@jrray.org>
In order to implement foreign traits for this type. Signed-off-by: J Robert Ray <jrray@jrray.org>
Fixes #1081. The bug causing #1081 was in `InstallSpec::is_default` as the logic was not updated when the `environment` field was added to the struct way back at https://github.com/spkenv/spk/blob/f4899ce1e4ac0634ee95608e322a86a358096d4d/src/api/install_spec.rs#L31 As a guard against this kind of bug in the future, an `IsDefault` trait was created and a derive macro created to derive the `is_default` method semi-automatically. All existing `is_default` methods have been changed to use the trait instead. Signed-off-by: J Robert Ray <jrray@jrray.org>
rydrman
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor various is_default() methods into IsDefault trait
Fixes #1081. The bug causing #1081 was in
InstallSpec::is_defaultas thelogic was not updated when the
environmentfield was added to the structway back at
spk/src/api/install_spec.rs
Line 31 in f4899ce
As a guard against this kind of bug in the future, an
IsDefaulttrait wascreated and a derive macro created to derive the
is_defaultmethodsemi-automatically. All existing
is_defaultmethods have been changed touse the trait instead.
And...
Refactor Package::runtime_environment
Both recipes and packages have the
install.environmentproperty, sorefactor
runtime_environment()out of thePackagetrait into its owntrait, then require both
RecipeandPackageimplement it.This change was prompted in order to make the code in the new test possible.