Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor various is_default() methods into IsDefault trait
Fixes #1081. The bug causing #1081 was in
InstallSpec::is_default
as thelogic was not updated when the
environment
field was added to the structway back at
spk/src/api/install_spec.rs
Line 31 in f4899ce
As a guard against this kind of bug in the future, an
IsDefault
trait wascreated and a derive macro created to derive the
is_default
methodsemi-automatically. All existing
is_default
methods have been changed touse the trait instead.
And...
Refactor Package::runtime_environment
Both recipes and packages have the
install.environment
property, sorefactor
runtime_environment()
out of thePackage
trait into its owntrait, then require both
Recipe
andPackage
implement it.This change was prompted in order to make the code in the new test possible.