-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support to spk commands for requests files #1130
base: main
Are you sure you want to change the base?
Conversation
From the meeting today:
|
e56c9f2
to
dc31e03
Compare
Updated this from the last meeting's feedback. Both pkg and var requests are supported now. The var requests are also used to make options for future templating renders inside |
From the meeting today:
Example: api: v0/requirements
options:
pypk.version: 1.0.0
python.abi: cp39
requirements:
- pkg: python/3
# we can't do this yet... but should be able to once #1135 is done
- var: '{{ opts.python.abi }}'
- var: python.abi/cp39
- {pkg: other, fromBuildEnv: true} # this is already an issue #1137 |
fb5c3e7
to
adeae26
Compare
I've added the options field to the requests/requirements files, and updated the processing to keep command line opts as overrides with priority for templating and solver options. I've removed the lines that turned the command line options into var requests, and confirmed these options don't seem to influence the solve now. This should be ready for another review. |
…quests This allows a larger number of request to be passed to spk bake, env and explain than would fit on a single command line. The yaml file must contain a list of package requests. Signed-off-by: David Gilligan-Cook <dcook@imageworks.com>
Signed-off-by: David Gilligan-Cook <dcook@imageworks.com>
adeae26
to
652c25f
Compare
This adds support to spk commands (
bake
,env
, andexplain
) to let them take files of package requests with a ` request on their command lines.The aim is to allow a larger number of package requests to be passed to spk command than would normally fit on a single command line. We're seeing examples of tools calling
spk bake
orspk explain
with 350+ detailed package requests, e.g.python/3.10.8+r3/ABCDEF
ormy-long-tool-name:{run,build,with-some-feature}/==1.2.3.4+r1
, not justpython
ormypkg
. Some of them are starting to hit command line limits and/or are becoming unwieldy to edit.Each file must a
yaml
formatted list of package or var requests.Example file (can have whatever is valid for a package request, json blob, '@' specifier, etc.):
Example command lines:
The package requests in the requests files are added to the list of requests first, before the ones on the command line.
See also: