Add timestamp to CI log lines #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… timestamp for spfs Signed-off-by: Nichol Yip <nyip@imageworks.com> Fixed if statement condition Signed-off-by: Nichol Yip <nyip@imageworks.com> (cherry picked from commit 18ca05b91ef4681147fd364004532118073a256b)
Fixed linting issue when adding timestamp to spfs configure logging Signed-off-by: Nichol Yip <nyip@imageworks.com> Fixed linting issues Signed-off-by: Nichol Yip <nyip@imageworks.com> (cherry picked from commit cfe114325c3b9cceba987b70b4c33e1098dd704c)
Signed-off-by: Nichol Yip <nyip@imageworks.com> (cherry picked from commit d3db14b1ea58350fca58932dce5bf4b318bd90c2)
For coverage that the project still compiles without that feature enabled. Signed-off-by: J Robert Ray <jrray@imageworks.com> Re-organized code to remove redundancy Signed-off-by: Nichol Yip <nyip@imageworks.com> (cherry picked from commit b18c7a962711ee93c0636b8edb8fb12ebf1813f0)
Signed-off-by: Nichol Yip <nyip@imageworks.com> (cherry picked from commit 091d537b1e3b5e2643caa02ad9cc7782dd7682c3)
nicholy
added
enhancement
Codecov Report
@@ Coverage Diff @@
## main #798 +/- ##
==========================================
+ Coverage 53.87% 54.06% +0.19%
==========================================
Files 248 248
Lines 19284 19343 +59
==========================================
+ Hits 10389 10458 +69
+ Misses 8895 8885 -10
... and 60 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rydrman
reviewed
Jul 18, 2023
Signed-off-by: Nichol Yip <nyip@imageworks.com> (cherry picked from commit cc7216e18cd1cc9caf32718df8ad5d27801782f4)
rydrman
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added feature to enable timestamp to CI log lines when the env var
SPFS_LOG_TIMESTAMPis present