Fix spk export failing if builds are missing #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our origin repo there are some traces of a package that may have been
partually published, where there are "spec build" tags but no "pkg build"
tags, as in:
spfs/tags/spk/spec/pkg-name/1.0.0/6XFZP6SR.tag (exists)
spfs/tags/spk/pkg/pkg-name (does not exist)
A _new_ build of this package failed to `spk export` due to these remnants
found in the origin repo:
INFO exporting pkg=pkg-name/1.0.0
INFO exporting pkg=pkg-name/1.0.0/src
INFO exporting pkg=pkg-name/1.0.0/5MDZ2ADM
WARN Ensure that you are specifying at least a package and
WARN version number when exporting from the local repository
ERROR Package not found: pkg-name/1.0.0/6XFZP6SR
This commit takes a minimally invasive approach of ignoring
PackageNotFoundError when these are generated about specific builds, as in
builds that exist as far as `list_package_builds` is concerned, but fail to
be loaded. It will still hard error if one attempts to export a specific
build that does not exist.
We don't think that we should have to manually remove the "spec build" tags
from our origin repo in order for `spk export` to work.
Signed-off-by: J Robert Ray <jrray@imageworks.com>
Codecov Report
@@ Coverage Diff @@
## main #800 +/- ##
==========================================
+ Coverage 53.87% 53.98% +0.10%
==========================================
Files 248 248
Lines 19284 19303 +19
==========================================
+ Hits 10389 10420 +31
+ Misses 8895 8883 -12
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rydrman
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our origin repo there are some traces of a package that may have been partually published, where there are "spec build" tags but no "pkg build" tags, as in:
A new build of this package failed to
spk exportdue to these remnants found in the origin repo:This commit takes a minimally invasive approach of ignoring PackageNotFoundError when these are generated about specific builds, as in builds that exist as far as
list_package_buildsis concerned, but fail to be loaded. It will still hard error if one attempts to export a specific build that does not exist.We don't think that we should have to manually remove the "spec build" tags from our origin repo in order for
spk exportto work.