-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store the solution's 'requested by' and 'repo name' data in an spfs annotation for spk to use #837
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #837 +/- ##
==========================================
+ Coverage 53.55% 53.87% +0.32%
==========================================
Files 258 253 -5
Lines 20466 20218 -248
==========================================
- Hits 10960 10893 -67
+ Misses 9506 9325 -181 ☔ View full report in Codecov by Sentry. |
Added some todo items, following a discussion today. |
af2d9dd
to
72f4164
Compare
8d07f98
to
1744610
Compare
72f4164
to
d1041a9
Compare
1744610
to
40ca8fc
Compare
d1041a9
to
ccb39db
Compare
40ca8fc
to
e7cf66c
Compare
ccb39db
to
31f51c0
Compare
e7cf66c
to
d1a71b5
Compare
31f51c0
to
1c75710
Compare
d1a71b5
to
40c28dd
Compare
1c75710
to
e7f0912
Compare
40c28dd
to
6591a3c
Compare
e7f0912
to
fcf11c5
Compare
6591a3c
to
f7e8aed
Compare
fcf11c5
to
f20b03b
Compare
f7e8aed
to
fee728d
Compare
0c40ba3
to
beca46f
Compare
fee728d
to
8e82514
Compare
beca46f
to
b6d0727
Compare
ed1e155
to
88d3920
Compare
06a8dd0
to
fe012c7
Compare
aa1fb04
to
e6901d9
Compare
fe012c7
to
f446fa3
Compare
Updated this for the external data to annotation name change. |
3ba643b
to
1af5c65
Compare
f446fa3
to
5eda518
Compare
d3d2f33
to
b213173
Compare
5eda518
to
03af1f8
Compare
b213173
to
d5285d6
Compare
03af1f8
to
c459ddb
Compare
d5285d6
to
5bec48e
Compare
c459ddb
to
07c7a97
Compare
… runtime Signed-off-by: David Gilligan-Cook <dcook@imageworks.com>
07c7a97
to
9cbbe80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall seems good - couple of questions/thoughts for you
Signed-off-by: David Gilligan-Cook <dcook@imageworks.com>
Signed-off-by: David Gilligan-Cook <dcook@imageworks.com>
Signed-off-by: David Gilligan-Cook <dcook@imageworks.com>
Signed-off-by: David Gilligan-Cook <dcook@imageworks.com>
This stores the Solution's 'requested by' data in the spfs runtime creates by spk commands, e.g.
spk env...
. The data is stored as an spfs annotation. spk commands run inside that runtime restore this data into the current environment'sSolution
object. This allows commands likespk info
to access the correct 'requested by' information, instead of making do with the placeholder "required by current environment" text.Originally, I looked at storing/restoring the full
Solution
data in the runtime, but theSolution
objects contain a lot data. Some of the data isn't easily serialisable, most of it is already reconstructed from the current runtime and repos incurrent_env()
, some of it applies for the initial solver run but doesn't inside a runtime, and the 'requested by' data that's part ofPkgRequest
objects that we need is marked toskip serialisation
(which is correct because we don't want this included in other places wherePkgRequest
are written out). So this change only stores/restores therequested by
data from the resolved packages in the originalSolution
in an annotation in spfs.Example, before this change:
> spk env python -- spk info -v Installed Packages: runtime/stdfs:{build,run}/=1.0.0/3I42H3S6 highest (required by current environment) runtime/python:{build,run}/=3.9.7/XO645NLV highest (required by current environment) Number of Packages: 2
And, after this change:
Installed Packages: runtime/stdfs:{build,run}/=1.0.0/3I42H3S6 highest (required by python/3.9.7/XO645NLV) runtime/python:{build,run}/=3.9.7/XO645NLV highest (required by command line) Number of Packages: 2
This requires the changes in #815 (spfs runtime extra data support)
Todo: