DRAFT: Add host_compat lints (requires spk-lint-update) #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
dcookspi
force-pushed
the
917-host-options-missing-lint
branch
from
6c9cf9d
to
3614fe1
Compare
Base automatically changed from
917-host-options-should-be-automatic-and-opt-out
to
main
December 12, 2023 20:28
…PR merged before it can compile and be tested Signed-off-by: David Gilligan-Cook <dcook@imageworks.com>
dcookspi
force-pushed
the
917-host-options-missing-lint
branch
from
3614fe1
to
9d7a941
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some
host_compat:related lints to theUncheckedBuildSpec. It is based on the #922 PR and thespk-lint-updatesbranch.This a a draft PR put in so people can see the proposed linting warnings for host_compat settings.
Note: It will fail to compile and fail the tests and checks, until the #851 PR is merged.
Todo: