Output lint summary after build #958
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
January 19, 2024 10:57
Signed-off-by: Nichol Yip <nyip@imageworks.com>
Signed-off-by: Nichol Yip <nyip@imageworks.com>
Signed-off-by: Nichol Yip <nyip@imageworks.com>
Signed-off-by: Nichol Yip <nyip@imageworks.com> Fixed error message when no similar configs are found. Added linting for EnvOp Signed-off-by: Nichol Yip <nyip@imageworks.com> Removed redudancy and simplified code. WIP: Generalizing LintedItem struct across all config types. Signed-off-by: Nichol Yip <nyip@imageworks.com> Added blanket implementation for LintedItem to generalize lints across all configs Signed-off-by: Nichol Yip <nyip@imageworks.com> Moved lint logic into separate file. Signed-off-by: Nichol Yip <nyip@imageworks.com> WIP: enum for lint messages Signed-off-by: Nichol Yip <nyip@imageworks.com> Moved lint error message inside new lint file. Fixed error message when unknown key is found. Implemented LintMessage enum for current variantions of lint error types. Signed-off-by: Nichol Yip <nyip@imageworks.com>
Signed-off-by: Nichol Yip <nyip@imageworks.com>
Signed-off-by: Nichol Yip <nyip@imageworks.com> WIP: Adding lint feature to source spec Signed-off-by: Nichol Yip <nyip@imageworks.com>
Removed lint from spk-schema/crates/ident Signed-off-by: Nichol Yip <nyip@imageworks.com>
Signed-off-by: Nichol Yip <nyip@imageworks.com>
Fixed configs to use Lint proc macro to generate lint messages WIP: Add Lint proc macro for EnvOp and TestSpec Signed-off-by: Nichol Yip <nyip@imageworks.com>
Signed-off-by: Nichol Yip <nyip@imageworks.com>
…-array crate instead. Signed-off-by: Nichol Yip <nyip@imageworks.com> Fixed linting errors and removed unused commented code. Signed-off-by: Nichol Yip <nyip@imageworks.com> Removed dead commented code and fixed du test with the correct sizes. Signed-off-by: Nichol Yip <nyip@imageworks.com> Fixed issue where no default source spec if found when no source provided Fixed issue with the default values for the meta struct when no values are provided Reverted du command tests back as it was related to the issue with the source spec. Signed-off-by: Nichol Yip <nyip@imageworks.com> Fixed typo in opentimelineio.spk.yaml Added render logic to linting command that caused some packages to return an error without it. Signed-off-by: Nichol Yip <nyip@imageworks.com> Added new line at EOF Signed-off-by: Nichol Yip <nyip@imageworks.com> Fixed changes from rebase that was not correctly added. Signed-off-by: Nichol Yip <nyip@imageworks.com> Removed shellexpand call from EnvOp Signed-off-by: Nichol Yip <nyip@imageworks.com> Moved crates to top level cargo.toml Changed linting feature to return an UnknownKey object instead of a generated string Modified new method for UnknownKey to store values needed to generated lint message Added enum for lints to support different kinds of lints Removed commented code Refactored render method and renamed render_lint -> render_to_string Signed-off-by: Nichol Yip <nyip@imageworks.com> Fixed changes from rebase Signed-off-by: Nichol Yip <nyip@imageworks.com> Fixed linting errors Signed-off-by: Nichol Yip <nyip@imageworks.com> WIP: Properly convert UncheckedBuildSpec -> BuildSpec Signed-off-by: Nichol Yip <nyip@imageworks.com> Implmented LintedBuildSpec struct to properly evaluate error if any, in the visitor method instead of the from implementation. Signed-off-by: Nichol Yip <nyip@imageworks.com> Removed redundant struct and replaced with using LintedItem instead. Signed-off-by: Nichol Yip <nyip@imageworks.com>
Signed-off-by: Nichol Yip <nyip@imageworks.com>
Signed-off-by: Nichol Yip <nyip@imageworks.com>
Signed-off-by: Nichol Yip <nyip@imageworks.com>
nicholy
added
enhancement
nicholy
force-pushed
the
spk-lint-update
branch
from
e8f7f43
to
e03d04d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional feature to the linting changes to show a summary of the generated lints if any exists.
Ex: