Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds CI jobs for SPI to cover the combinations of digest_strategy and encoding_format #965

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ jobs:
uses: crazy-max/ghaction-chocolatey@v3
with:
args: install protoc llvm winfsp make
- name: Install FlatBuffers Compiler
run: |
$url = "https://github.com/google/flatbuffers/releases/download/v23.5.26/Windows.flatc.binary.zip"
Invoke-WebRequest $url -OutFile C:\flatc.zip
Expand-Archive C:\flatc.zip -DestinationPath C:\Windows
- name: Install Debug SPFS
run: |
make install-debug-spfs
Expand Down Expand Up @@ -54,6 +59,9 @@ jobs:
apt-get install -y libcap2-bin sudo cmake tcsh rsync protobuf-compiler fuse libfuse-dev
# spfs-fuse requires this option enabled
echo user_allow_other >> /etc/fuse.conf
FB_REL=https://github.com/google/flatbuffers/releases/
curl --proto '=https' --tlsv1.2 -sSfL ${FB_REL}/download/v23.5.26/Linux.flatc.binary.g++-10.zip | funzip > /usr/bin/flatc
chmod +x /usr/bin/flatc
rustup install nightly
rustup component add clippy
rustup component add rustfmt --toolchain nightly
Expand Down
41 changes: 41 additions & 0 deletions .site/spi/.spdev.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ components:
- proxy
variables:
FEATURES: migration-to-components,sentry,spfs/protobuf-src
# Current defaults, may change layer
SPFS_STORAGE__DIGEST_STRATEGY: Legacy
SPFS_STORAGE__ENCODING_FORMAT: Legacy
jrray marked this conversation as resolved.
Show resolved Hide resolved

- kind: RustCrate
name: spk-no-sentry
Expand All @@ -34,6 +37,44 @@ components:
- proxy
variables:
FEATURES: migration-to-components,spfs/protobuf-src
SPFS_STORAGE__DIGEST_STRATEGY: Legacy
SPFS_STORAGE__ENCODING_FORMAT: Legacy

- kind: RustCrate
name: spk-withkindandsalt-flatbuffers
ci_config:
parallel: true
tags:
- proxy
variables:
FEATURES: migration-to-components,sentry,spfs/protobuf-src
# New digests and new encoding
SPFS_STORAGE__DIGEST_STRATEGY: WithKindAndSalt
SPFS_STORAGE__ENCODING_FORMAT: FlatBuffers

- kind: RustCrate
name: spk-legacy-flatbuffers
ci_config:
parallel: true
tags:
- proxy
variables:
FEATURES: migration-to-components,sentry,spfs/protobuf-src
# Legacy digests and new encoding
SPFS_STORAGE__DIGEST_STRATEGY: Legacy
SPFS_STORAGE__ENCODING_FORMAT: FlatBuffers

- kind: RustCrate
name: spk-withkindandsalt-legacy
ci_config:
parallel: true
tags:
- proxy
variables:
FEATURES: migration-to-components,sentry,spfs/protobuf-src
# New digests and legacy encoding
SPFS_STORAGE__DIGEST_STRATEGY: WithKindAndSalt
SPFS_STORAGE__ENCODING_FORMAT: Legacy

- kind: HugoDocs
name: docs
Expand Down
112 changes: 90 additions & 22 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading