Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metric Ruleset Archived Metrics #491

Merged
merged 11 commits into from
Aug 21, 2024
Merged

Metric Ruleset Archived Metrics #491

merged 11 commits into from
Aug 21, 2024

Conversation

echoi-splk
Copy link
Collaborator

@echoi-splk echoi-splk commented Aug 2, 2024 •
edited
Loading

Requires signalfx/signalfx-go#223 to be merged and new signalfx-go lib to be published.

Adds support for Archived Metrics in Metric Rulesets:

  • ability to route metric to "Archived"
  • ability to define exception rules and restoration jobs

@echoi-splk echoi-splk self-assigned this Aug 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@echoi-splk
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

srv-gh-o11y-gdi-cla added a commit to splunk/cla-agreement that referenced this pull request Aug 20, 2024
@srv-gh-o11y-gdi-cla
@echoi-splk has signed the CLA in splunk-terraform/terraform-provider…
698312e 
…-signalfx#491
@echoi-splk echoi-splk changed the title Draft: Metricruleset arm Metric Ruleset Archived Metrics Aug 20, 2024
@echoi-splk echoi-splk marked this pull request as ready for review August 20, 2024 23:57
kevalds51
kevalds51 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@kevalds51 kevalds51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@echoi-splk echoi-splk merged commit b20ad57 into main Aug 21, 2024
3 checks passed
@echoi-splk echoi-splk deleted the metricruleset-arm branch August 21, 2024 18:39
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kevalds51 kevalds51 kevalds51 approved these changes

@ndmoeller ndmoeller Awaiting requested review from ndmoeller ndmoeller is a code owner

@atoulme atoulme Awaiting requested review from atoulme atoulme is a code owner

@benkeith-splunk benkeith-splunk Awaiting requested review from benkeith-splunk

Assignees

@echoi-splk echoi-splk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@echoi-splk @kevalds51