Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added trim to topic names to remove leading whitespace if exists #432

Merged
merged 1 commit into from
May 22, 2024

Conversation

ravib777
Copy link
Contributor

@ravib777 ravib777 commented May 3, 2024

Problem

If multiple topics are provided in the list with an intention to write data to corresponding index, example:
"topics":` "splunk-qs, splunk-abc",
"splunk.indexes": "index1,index2",

the leading space before splunk-abc will cause the mapping to not work and instead of writing to index2, the connector will write all messages from splunk-abc topic to default index (main).

Solution

Trim topic name before adding it to the map

Does this solution apply anywhere else?
  • yes
  • [ x] no
If yes, where?

Test Strategy

Testing done:
  • Unit tests
  • Integration tests
  • System tests
  • [x ] Manual tests

Release Plan

@ravib777 ravib777 temporarily deployed to workflow-approval May 3, 2024 03:35 — with GitHub Actions Inactive
Copy link

Unit Test Results

172 tests   172 ✅  37s ⏱️
 24 suites    0 💤
 24 files      0 ❌

Results for commit ffa8355.

@wojtekzyla wojtekzyla merged commit 7c108cc into splunk:develop May 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants