Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 434: Add connector level proxy configurations #436

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

wangshu3000
Copy link

This is a PR to fix issue: #434

In this PR, i added 2 parameters to the connector configurations.
splunk.hec.http.proxy.host - The proxy host
splunk.hec.http.proxy.port - The proxy port

This proxy is setup at the connector level, the splunk connector can use it's own proxy.
If these 2 parameters were configured, it'll use this proxy when connecting to HEC endpoint.
Otherwise, it'll use the JVM level proxy setting in JVM_OPTS.

This provides us the capability to use a different proxy for this connector. No matter how the global JVM_OPTS proxy was configured.

@wangshu3000 wangshu3000 changed the title Fix issue 434 Fix issue 434: Add connector level proxy configurations Jun 24, 2024
@wangshu3000
Copy link
Author

Hi @wojtekzyla @VihasMakwana
Could you please hep to review this PR if you have time?
This is a PR to add proxy related configuration settings, so that we can configure connector level proxy.

Thanks.

@wojtekzyla
Copy link
Collaborator

Hi @wangshu3000 sure I'll review this

README.md Outdated Show resolved Hide resolved
@wangshu3000
Copy link
Author

@wojtekzyla Not sure if you got chance to review my change, i have updated the description based on your suggestion. Could you please have a review? Thanks.

@shijiadong2022
Copy link

@wojtekzyla I wonder if you could help review this one when you have a chance?

@wojtekzyla wojtekzyla self-requested a review October 22, 2024 09:14
@wojtekzyla
Copy link
Collaborator

Could you add some empty commit to restart the workflow?

Signed-off-by: Wang, Shu <shu.wang@fmr.com>
@wangshu3000
Copy link
Author

Thanks @wojtekzyla for your approval, i have retriggered the CI Build Test, could you please approve the flow? Thanks.

Copy link

Unit Test Results

175 tests   175 ✅  38s ⏱️
 24 suites    0 💤
 24 files      0 ❌

Results for commit b45a55d.

@wangshu3000
Copy link
Author

Thanks @wojtekzyla
Looks like the CI Build was failed at fossa-scan step, looks like some dependencies are not compliant, not sure if i should bump the version in my PR or it can be bypassed?

@wojtekzyla
Copy link
Collaborator

Thanks @wojtekzyla Looks like the CI Build was failed at fossa-scan step, looks like some dependencies are not compliant, not sure if i should bump the version in my PR or it can be bypassed?

Yes, if you could do that it would be helpful. You could also add it to PR description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants