-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 434: Add connector level proxy configurations #436
base: develop
Are you sure you want to change the base?
Conversation
Hi @wojtekzyla @VihasMakwana Thanks. |
Hi @wangshu3000 sure I'll review this |
2498574
to
c6b8471
Compare
@wojtekzyla Not sure if you got chance to review my change, i have updated the description based on your suggestion. Could you please have a review? Thanks. |
@wojtekzyla I wonder if you could help review this one when you have a chance? |
Could you add some empty commit to restart the workflow? |
Signed-off-by: Wang, Shu <shu.wang@fmr.com>
c6b8471
to
b45a55d
Compare
Thanks @wojtekzyla for your approval, i have retriggered the CI Build Test, could you please approve the flow? Thanks. |
Unit Test Results175 tests 175 ✅ 38s ⏱️ Results for commit b45a55d. |
Thanks @wojtekzyla |
Yes, if you could do that it would be helpful. You could also add it to PR description |
This is a PR to fix issue: #434
In this PR, i added 2 parameters to the connector configurations.
splunk.hec.http.proxy.host - The proxy host
splunk.hec.http.proxy.port - The proxy port
This proxy is setup at the connector level, the splunk connector can use it's own proxy.
If these 2 parameters were configured, it'll use this proxy when connecting to HEC endpoint.
Otherwise, it'll use the JVM level proxy setting in JVM_OPTS.
This provides us the capability to use a different proxy for this connector. No matter how the global JVM_OPTS proxy was configured.