Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix arista eos miscategorized as cisco ios #2146

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

mstopa-splunk
Copy link
Contributor

@mstopa-splunk mstopa-splunk commented Aug 23, 2023

In #2139 it has been reported that some Arista EOS logs are miscategorized as Cisco IOS.

In fact those two vendors use a very similar log format.
The difference is Arista will always contain program name before the first colon:
Aug 18 03:36:42 AleL3Agent-primary: %AGENT-6-INITIALIZED: Agent 'AleL3Agent-primary' initialized; pid=XXXX

In Cisco there is usually just a timestamp:
Feb 14 09:40:10.326: %LINEPROTO-5-UPDOWN: Line protocol on Interface GigabitEthernet0/1, changed state to up

Sometimes timestamp with timezone:
{{ mark }}: {{ year }} {{ bsd }} PDT: %DAEMON-3-SYSTEM_MSG: ftp disabled, removing - xinetd[4930] {{ host }}

And sometimes also program name, but with all letters uppercase:
'{{ mark }}{{ bsd }} SYSMGR[919]: %Viptela-{{ host }}-sysmgrd-6-INFO-1400002: Notification: 3/17/2022 18:35:12 system-login-change severity-level:minor host-name:"{{ host }}" system-ip:1.1.1.3 user-name:"mn2c" user-id:2227\n'

This PR adds new test cases based on the customer issue, as well as updates Cisco and Arista parsers to properly catch the differences

@mstopa-splunk mstopa-splunk marked this pull request as ready for review August 23, 2023 15:21
@mstopa-splunk mstopa-splunk merged commit 6183880 into main Aug 25, 2023
14 of 15 checks passed
@mstopa-splunk mstopa-splunk deleted the fix/arista-eos-miscategorized-as-cisco-ios branch August 25, 2023 09:10
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2023
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 3.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants