Skip to content

Commit

Permalink
fix: add proper log message when argo logs yields with EOF error (#34)
Browse files Browse the repository at this point in the history
This PR provides proper log message when the EOF error appears while
performing argo logs --follow operation. It caused a lot of confusion
among developers, since it looked like the tests stopped being performed
(although they were still in progress). The developers used to
unnecessarily re-trigger tests in this case.

The message should be enough. Optionally, we could also add one or two
retries of argo logs --follow while getting EOF error
(https://grpc.github.io/grpc/core/md_doc_statuscodes.html)
  • Loading branch information
kdoroszko-splunk committed Sep 11, 2024
1 parent 13162a5 commit f2ba058
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ outputs:
description: 'Name of workflow triggered'
runs:
using: 'docker'
image: 'docker://ghcr.io/splunk/wfe-test-runner-action/wfe-test-runner-action:v5.0.1'
image: 'Dockerfile'
args:
- ${{ inputs.workflow-tmpl-name }}
- ${{ inputs.workflow-template-ns }}
Expand Down
2 changes: 1 addition & 1 deletion entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ echo "After argo submit $?"
echo 'WORKFLOW_NAME:' ${WORKFLOW_NAME}
echo "workflow-name=$(echo $WORKFLOW_NAME)" >> $GITHUB_OUTPUT

argo logs --follow ${WORKFLOW_NAME} -n ${2}
argo logs --follow ${WORKFLOW_NAME} -n ${2} || echo "... There was an error fetching the logs. The workflow is still in progress, and the tests are still running. The results will be available in the Test Report step. Please wait for the workflow to complete. ..."

0 comments on commit f2ba058

Please sign in to comment.