Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace runInTerminal with unixCmd #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

madskjeldgaard
Copy link
Contributor

Hi !

On Linux, the runInTerminal method will most likely emit an error about not being able to find xterm (see supercollider/supercollider#4994). Therefore, this is a PR with an alternative suggestion: unixCmd. This will always work :)

@spluta
Copy link
Owner

spluta commented Aug 7, 2021

Thanks for this Mads. I appreciate your feedback. The issue is that on the mac, this just does nothing. It just doesn't run. But you are saying that on Linux, it works? I guess the better fix would be to check which OS the user is on and execute the desired method. Do you know what works on Windows?

edit: Hmm. Maybe unixCmd wasn't working because of BigSur....I'll be back.
edit2: No. I've run into this before.

Could you test this:

		if(thisProcess.platform.asSymbol=='an OSXPlatform'){
			AppClock.sched((1), {("sclang "++fileName++"_"++chanNum++".scd").postln.runInTerminal});
		}{
			if(thisProcess.platform.asSymbol=='a LinuxPlatform'){
				AppClock.sched((1), {("sclang "++fileName++"_"++chanNum++".scd").postln.unixCmd});
			}
		}{
			"stretch2PlusChannels only works on mac or linux"
		}

@elgiano
Copy link

elgiano commented Sep 2, 2021

Just a comment here: as mads pointed out, runInTerminal has this problem on Linux, but it will be fixed in SC 3.12 as it is already fixed in branch develop:
supercollider/supercollider#4893 (comment)

@madskjeldgaard
Copy link
Contributor Author

Just a comment here: as mads pointed out, runInTerminal has this problem on Linux, but it will be fixed in SC 3.12 as it is already fixed in branch develop:
supercollider/supercollider#4893 (comment)

Yeah this is really fantastic but for fixed release linux distros it's going to be a while before they hit 3.12 (although Debian bullseye is already at 3.11.2 it seems). But yeah it's a tiny and perhaps theoretical problem now that 3.12 is out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants