Skip to content

Commit

Permalink
image_patch_dev.sh: set pipefail (kserve#3274)
Browse files Browse the repository at this point in the history
This makes the script fail when something in a pipe fails. With this
`make deploy-dev` actually fail on the right line when something is
failing instead of getting an unrelated error on on other scripts.

For the record: `ko resolve` was failing because `KO_DOCKER_REPO` was
unset.

Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com>
  • Loading branch information
dtrifiro authored Dec 3, 2023
1 parent 346ead8 commit 05303d7
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions hack/image_patch_dev.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
# Usage: image_patch_dev.sh [OVERLAY]
set -u
set -e
set -o pipefail

OVERLAY=$1
IMG=$(ko resolve -f config/manager/manager.yaml | grep 'image:' | head -1 | awk '{print $2}')
if [ -z ${IMG} ]; then exit; fi
Expand Down

0 comments on commit 05303d7

Please sign in to comment.