Skip to content

Commit

Permalink
Dropped support for Python 3.8 which is past EOL
Browse files Browse the repository at this point in the history
  • Loading branch information
spookylukey committed Dec 27, 2024
1 parent 89c30ba commit 6d68ffa
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [3.8, 3.9, "3.10", "3.11", "3.12", "3.13"]
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]

steps:
- uses: actions/checkout@v4
Expand Down
1 change: 1 addition & 0 deletions docs/history.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ Version 1.4 - unreleased
* Added ``python_file_processor`` parameter to :func:`pyastgrep.api.search_python_files`,
which particularly serves the needs of people using pyastgrep as a library who
want to apply caching.
* Dropped support for Python 3.8.

Version 1.3.2 - 2024-01-10
--------------------------
Expand Down
2 changes: 1 addition & 1 deletion docs/install.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
Installation
============

Python 3.8+ required.
Python 3.9+ required.

We recommend `pipx <https://pipxproject.github.io/pipx/>`_ to install it
conveniently in an isolated environment:
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,18 @@ classifiers = [
"Development Status :: 4 - Beta",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Intended Audience :: Developers",
"Operating System :: OS Independent",
"License :: OSI Approved :: MIT License",
"Natural Language :: English",
]
urls = {Homepage = "https://github.com/spookylukey/pyastgrep"}
requires-python = ">=3.8"
requires-python = ">=3.9"
dependencies = [
"lxml>=3.3.5",
"elementpath",
Expand Down
2 changes: 0 additions & 2 deletions tests/test_xml.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
from pathlib import Path

import lxml.etree
import pytest
from pyastgrep.asts import ast_to_xml
from pyastgrep.files import parse_python_file

Expand Down Expand Up @@ -102,7 +101,6 @@ def _file_to_xml(path: Path):
return lxml.etree.tostring(doc, pretty_print=True).decode("utf-8")


@pytest.mark.skipif(sys.version_info < (3, 9), reason="AST different on Python 3.8")
def test_xml_everything():
# Smoke test to check we didn't break anything.
EXPECTED = """
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tox]
# Remember to add to .github/workflows/tests.yml if this is added to.
envlist = py38, py39, py310, py311, py312, py313, pyright
envlist = py39, py310, py311, py312, py313, pyright

[testenv]
commands = pytest {posargs}
Expand Down

0 comments on commit 6d68ffa

Please sign in to comment.