Skip to content

Commit

Permalink
[pom] Adjust codenarc but skip it
Browse files Browse the repository at this point in the history
codenarc doesn't work for the groovy version we are using nor does it handle modern java properly.  The plugin will need separately forked and updated to continue using, for now, just disable it as the code is pretty well written that it is not likely to complain much.
  • Loading branch information
hazendaz committed Dec 2, 2024
1 parent ae51b18 commit f6a0d1d
Showing 1 changed file with 20 additions and 1 deletion.
21 changes: 20 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,7 @@
<beanutils.version>1.9.4</beanutils.version>
<chain.version>1.2</chain.version>
<codec.version>1.17.1</codec.version>
<codenarc.version>3.5.0-groovy-4.0</codenarc.version>
<collections.version>3.2.2</collections.version>
<digester.version>2.1</digester.version>
<gson.version>2.11.0</gson.version>
Expand Down Expand Up @@ -666,6 +667,22 @@
</mapping>
</configuration>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>codenarc-maven-plugin</artifactId>
<version>${codenarcPluginVersion}</version>
<configuration>
<!-- Repo https://github.com/gleclaire/codenarc-maven-plugin has been forked and will need major upgrades to use this. -->
<skip>true</skip>
</configuration>
<dependencies>
<dependency>
<groupId>org.codenarc</groupId>
<artifactId>CodeNarc</artifactId>
<version>${codenarc.version}</version>
</dependency>
</dependencies>
</plugin>
</plugins>
</pluginManagement>

Expand Down Expand Up @@ -783,11 +800,13 @@
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>codenarc-maven-plugin</artifactId>
<version>${codenarcPluginVersion}</version>
<configuration>
<codeNarcVersion>${codenarc.version}</codeNarcVersion>
<groovyVersion>${groovyVersion}</groovyVersion>
<maxPriority1Violations>0</maxPriority1Violations>
<maxPriority2Violations>0</maxPriority2Violations>
<maxPriority3Violations>5</maxPriority3Violations>
<sourceDirectory>${project.basedir}/src/main/groovy</sourceDirectory>
</configuration>
</plugin>
<plugin>
Expand Down

0 comments on commit f6a0d1d

Please sign in to comment.