spotbugs · hazendaz · Oct 15, 2023 · Oct 12, 2023 · Oct 12, 2023 · Oct 12, 2023
diff --git a/pom.xml b/pom.xml
@@ -28,7 +28,7 @@
 
   <groupId>com.github.spotbugs</groupId>
   <artifactId>spotbugs-maven-plugin</artifactId>
-  <version>4.7.3.7-SNAPSHOT</version>
+  <version>4.8.0.0-SNAPSHOT</version>
   <packaging>maven-plugin</packaging>
 
   <name>spotbugs-maven-plugin</name>
@@ -167,11 +167,11 @@
     <project.build.outputTimestamp>1695603053</project.build.outputTimestamp>
 
     <!-- Override spotbugs to this version from base-parent -->
-    <spotbugs.version>4.7.3</spotbugs.version>
+    <spotbugs.version>4.8.0</spotbugs.version>
 
-    <junitVersion>5.9.3</junitVersion>
-    <spotbugsVersion>4.7.3</spotbugsVersion>
-    <spotbugsTag>4.7.3</spotbugsTag>
+    <junitVersion>5.10.0</junitVersion>
+    <spotbugsVersion>4.8.0</spotbugsVersion>
+    <spotbugsTag>4.8.0</spotbugsTag>
     <slf4jVersion>2.0.9</slf4jVersion>
 
     <antVersion>1.10.14</antVersion>
@@ -191,7 +191,8 @@
 
     <plexusContainerVersion>2.1.1</plexusContainerVersion>
     <plexusResourcesVersion>1.2.0</plexusResourcesVersion>
-    <plexusUtilsVersion>3.5.1</plexusUtilsVersion>
+    <plexusUtilsVersion>4.0.0</plexusUtilsVersion>
+    <plexusXmlVersion>3.0.0</plexusXmlVersion>
 
     <antrunPluginVersion>3.1.0</antrunPluginVersion>
     <l10nPluginVersion>1.0.0</l10nPluginVersion>
@@ -222,7 +223,7 @@
     <compilerPluginVersion>3.11.0</compilerPluginVersion>
     <findsecbugsVersion>1.12.0</findsecbugsVersion>
     <jxrPluginVersion>3.3.0</jxrPluginVersion>
-    <mavenSurefireVersion>3.0.0</mavenSurefireVersion>
+    <mavenSurefireVersion>3.1.2</mavenSurefireVersion>
     <jakartaeeApiVersion>8.0.0</jakartaeeApiVersion>
     <servletApiVersion>4.0.4</servletApiVersion>
     <sb-contribVersion>7.6.0</sb-contribVersion>
@@ -246,9 +247,6 @@
 
     <!-- Automatic Module Name -->
     <module.name>com.github.spotbugs.maven</module.name>
-
-    <!-- TODO: Overrice parent for latest enforcer rules: Remove with parent 41. -->
-    <extra-enforcer-rules.version>1.7.0</extra-enforcer-rules.version>
   </properties>
 
   <dependencyManagement>
@@ -602,6 +600,11 @@
       <artifactId>plexus-utils</artifactId>
       <version>${plexusUtilsVersion}</version>
     </dependency>
+    <dependency>
+      <groupId>org.codehaus.plexus</groupId>
+      <artifactId>plexus-xml</artifactId>
+      <version>${plexusXmlVersion}</version>
+    </dependency>
   </dependencies>
 
   <build>

diff --git a/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline-other.xml b/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline-other.xml
@@ -16,7 +16,7 @@
     limitations under the License.
 
 -->
-<BugCollection sequence="0" release="" analysisTimestamp="1653586688929" version="4.7.0" timestamp="1653586685292">
+<BugCollection sequence="0" release="" analysisTimestamp="1697396613578" version="4.8.0" timestamp="1697396611249">
   <BugInstance instanceOccurrenceNum="0" instanceHash="c7f9edd192cfef80d2e55dde64a514bc" rank="2" abbrev="INT" category="CORRECTNESS" priority="1" type="INT_BAD_COMPARISON_WITH_SIGNED_BYTE" instanceOccurrenceMax="0">
     <ShortMessage>Bad comparison of signed byte</ShortMessage>
     <LongMessage>Bad comparison of signed byte with 200 in AssumeUnsignedBytes.find200(byte[])</LongMessage>
@@ -54,6 +54,33 @@
       <Message>At UseOfNonHashableClassInHashDataStructure.java:[line 16]</Message>
     </SourceLine>
   </BugInstance>
+  <BugInstance instanceOccurrenceNum='0' instanceHash='39b83e2bc727181dff8f79450a6ccedb' rank='1' abbrev='HE' category='CORRECTNESS' priority='1' type='HE_USE_OF_UNHASHABLE_CLASS' instanceOccurrenceMax='0'>
+    <ShortMessage>Use of class without a hashCode() method in a hashed data structure</ShortMessage>
+    <LongMessage>UseOfNonHashableClassInHashDataStructure doesn't define a hashCode() method but is used in a hashed data structure in UseOfNonHashableClassInHashDataStructure.get(UseOfNonHashableClassInHashDataStructure)</LongMessage>
+    <Class classname='UseOfNonHashableClassInHashDataStructure' primary='true'>
+      <SourceLine classname='UseOfNonHashableClassInHashDataStructure' start='3' end='24' sourcepath='UseOfNonHashableClassInHashDataStructure.java' sourcefile='UseOfNonHashableClassInHashDataStructure.java'>
+        <Message>At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24]</Message>
+      </SourceLine>
+      <Message>In class UseOfNonHashableClassInHashDataStructure</Message>
+    </Class>
+    <Method isStatic='true' classname='UseOfNonHashableClassInHashDataStructure' signature='(LUseOfNonHashableClassInHashDataStructure;)Ljava/lang/String;' name='get' primary='true'>
+      <SourceLine endBytecode='34' classname='UseOfNonHashableClassInHashDataStructure' start='24' end='24' sourcepath='UseOfNonHashableClassInHashDataStructure.java' sourcefile='UseOfNonHashableClassInHashDataStructure.java' startBytecode='0'></SourceLine>
+      <Message>In method UseOfNonHashableClassInHashDataStructure.get(UseOfNonHashableClassInHashDataStructure)</Message>
+    </Method>
+    <Type role='TYPE_UNHASHABLE' descriptor='LUseOfNonHashableClassInHashDataStructure;'>
+      <SourceLine classname='UseOfNonHashableClassInHashDataStructure' start='3' end='24' sourcepath='UseOfNonHashableClassInHashDataStructure.java' sourcefile='UseOfNonHashableClassInHashDataStructure.java'>
+        <Message>At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24]</Message>
+      </SourceLine>
+      <Message>Unhashable class UseOfNonHashableClassInHashDataStructure </Message>
+    </Type>
+    <Method isStatic='false' role='METHOD_CALLED' classname='java.util.HashMap' signature='(Ljava/lang/Object;)Ljava/lang/Object;' name='get'>
+      <SourceLine endBytecode='130' classname='java.util.HashMap' start='553' end='553' sourcepath='java/util/HashMap.java' sourcefile='HashMap.java' startBytecode='0'></SourceLine>
+      <Message>Called method java.util.HashMap.get(Object)</Message>
+    </Method>
+    <SourceLine endBytecode='4' classname='UseOfNonHashableClassInHashDataStructure' start='24' end='24' sourcepath='UseOfNonHashableClassInHashDataStructure.java' sourcefile='UseOfNonHashableClassInHashDataStructure.java' startBytecode='4' primary='true'>
+      <Message>At UseOfNonHashableClassInHashDataStructure.java:[line 24]</Message>
+    </SourceLine>
+  </BugInstance>
   <BugInstance instanceOccurrenceNum="0" instanceHash="a4564c101ee03f13b56ee6a6b66efd77" rank="5" abbrev="HE" category="CORRECTNESS" priority="1" type="HE_SIGNATURE_DECLARES_HASHING_OF_UNHASHABLE_CLASS" instanceOccurrenceMax="0">
     <ShortMessage>Signature declares use of unhashable class in hashed construct</ShortMessage>
     <LongMessage>UseOfNonHashableClassInHashDataStructure doesn't define a hashCode() method but it is used in a hashed context in UseOfNonHashableClassInHashDataStructure$UMap</LongMessage>

diff --git a/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline.xml b/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline.xml
@@ -16,7 +16,7 @@
     limitations under the License.
 
 -->
-<BugCollection sequence="0" release="" analysisTimestamp="1653586688929" version="4.7.0" timestamp="1653586685292">
+<BugCollection sequence="0" release="" analysisTimestamp="1697396613578" version="4.8.0" timestamp="1697396611249">
   <BugInstance instanceOccurrenceNum="0" instanceHash="a7786a4e4e4b9291a71529139eda42d1" rank="5" abbrev="IO" category="CORRECTNESS" priority="1" type="IO_APPENDING_TO_OBJECT_OUTPUT_STREAM" instanceOccurrenceMax="0">
     <ShortMessage>Doomed attempt to append to an object output stream</ShortMessage>
     <LongMessage>Doomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject1(File, Object)</LongMessage>
@@ -122,6 +122,33 @@
       <Message>At UseOfNonHashableClassInHashDataStructure.java:[line 16]</Message>
     </SourceLine>
   </BugInstance>
+  <BugInstance instanceOccurrenceNum='0' instanceHash='39b83e2bc727181dff8f79450a6ccedb' rank='1' abbrev='HE' category='CORRECTNESS' priority='1' type='HE_USE_OF_UNHASHABLE_CLASS' instanceOccurrenceMax='0'>
+    <ShortMessage>Use of class without a hashCode() method in a hashed data structure</ShortMessage>
+    <LongMessage>UseOfNonHashableClassInHashDataStructure doesn't define a hashCode() method but is used in a hashed data structure in UseOfNonHashableClassInHashDataStructure.get(UseOfNonHashableClassInHashDataStructure)</LongMessage>
+    <Class classname='UseOfNonHashableClassInHashDataStructure' primary='true'>
+      <SourceLine classname='UseOfNonHashableClassInHashDataStructure' start='3' end='24' sourcepath='UseOfNonHashableClassInHashDataStructure.java' sourcefile='UseOfNonHashableClassInHashDataStructure.java'>
+        <Message>At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24]</Message>
+      </SourceLine>
+      <Message>In class UseOfNonHashableClassInHashDataStructure</Message>
+    </Class>
+    <Method isStatic='true' classname='UseOfNonHashableClassInHashDataStructure' signature='(LUseOfNonHashableClassInHashDataStructure;)Ljava/lang/String;' name='get' primary='true'>
+      <SourceLine endBytecode='34' classname='UseOfNonHashableClassInHashDataStructure' start='24' end='24' sourcepath='UseOfNonHashableClassInHashDataStructure.java' sourcefile='UseOfNonHashableClassInHashDataStructure.java' startBytecode='0'></SourceLine>
+      <Message>In method UseOfNonHashableClassInHashDataStructure.get(UseOfNonHashableClassInHashDataStructure)</Message>
+    </Method>
+    <Type role='TYPE_UNHASHABLE' descriptor='LUseOfNonHashableClassInHashDataStructure;'>
+      <SourceLine classname='UseOfNonHashableClassInHashDataStructure' start='3' end='24' sourcepath='UseOfNonHashableClassInHashDataStructure.java' sourcefile='UseOfNonHashableClassInHashDataStructure.java'>
+        <Message>At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24]</Message>
+      </SourceLine>
+      <Message>Unhashable class UseOfNonHashableClassInHashDataStructure </Message>
+    </Type>
+    <Method isStatic='false' role='METHOD_CALLED' classname='java.util.HashMap' signature='(Ljava/lang/Object;)Ljava/lang/Object;' name='get'>
+      <SourceLine endBytecode='130' classname='java.util.HashMap' start='553' end='553' sourcepath='java/util/HashMap.java' sourcefile='HashMap.java' startBytecode='0'></SourceLine>
+      <Message>Called method java.util.HashMap.get(Object)</Message>
+    </Method>
+    <SourceLine endBytecode='4' classname='UseOfNonHashableClassInHashDataStructure' start='24' end='24' sourcepath='UseOfNonHashableClassInHashDataStructure.java' sourcefile='UseOfNonHashableClassInHashDataStructure.java' startBytecode='4' primary='true'>
+      <Message>At UseOfNonHashableClassInHashDataStructure.java:[line 24]</Message>
+    </SourceLine>
+  </BugInstance>
   <BugInstance instanceOccurrenceNum="0" instanceHash="a4564c101ee03f13b56ee6a6b66efd77" rank="5" abbrev="HE" category="CORRECTNESS" priority="1" type="HE_SIGNATURE_DECLARES_HASHING_OF_UNHASHABLE_CLASS" instanceOccurrenceMax="0">
     <ShortMessage>Signature declares use of unhashable class in hashed construct</ShortMessage>
     <LongMessage>UseOfNonHashableClassInHashDataStructure doesn't define a hashCode() method but it is used in a hashed context in UseOfNonHashableClassInHashDataStructure$UMap</LongMessage>

diff --git a/src/it/MFINDBUGS-178/pom.xml b/src/it/MFINDBUGS-178/pom.xml
@@ -26,8 +26,8 @@
     <version>testing</version>
     <relativePath>../common.xml</relativePath>
   </parent>
-  <artifactId>check</artifactId>
-  <name>check</name>
+  <artifactId>MFINDBUGS-178</artifactId>
+  <name>MFINDBUGS-178</name>
   <packaging>jar</packaging>
   <build>
     <plugins>

diff --git a/src/it/change-xml-filename/pom.xml b/src/it/change-xml-filename/pom.xml
@@ -26,8 +26,8 @@
     <version>testing</version>
     <relativePath>../common.xml</relativePath>
   </parent>
-  <artifactId>change-filename</artifactId>
-  <name>change-filename</name>
+  <artifactId>change-xml-filename</artifactId>
+  <name>change-xml-filename</name>
   <packaging>jar</packaging>
   <reporting>
     <excludeDefaults>true</excludeDefaults>

diff --git a/src/it/check-fail/pom.xml b/src/it/check-fail/pom.xml
@@ -26,8 +26,8 @@
     <version>testing</version>
     <relativePath>../common.xml</relativePath>
   </parent>
-  <artifactId>check</artifactId>
-  <name>check</name>
+  <artifactId>check-fail</artifactId>
+  <name>check-fail</name>
   <packaging>jar</packaging>
   <build>
     <plugins>

diff --git a/src/it/check-failThreshold/pom.xml b/src/it/check-failThreshold/pom.xml
@@ -26,8 +26,8 @@
     <version>testing</version>
     <relativePath>../common.xml</relativePath>
   </parent>
-  <artifactId>check</artifactId>
-  <name>check</name>
+  <artifactId>check-failThreshold</artifactId>
+  <name>check-failThreshold</name>
   <packaging>jar</packaging>
   <build>
     <plugins>

diff --git a/src/it/check-multi-filter-dups/module1/pom.xml b/src/it/check-multi-filter-dups/module1/pom.xml
@@ -22,7 +22,7 @@
   <modelVersion>4.0.0</modelVersion>
   <parent>
     <groupId>spotbugs-maven-plugin.it</groupId>
-    <artifactId>check-multi-parent-relative-path</artifactId>
+    <artifactId>check-multi-filter-dups</artifactId>
     <version>testing</version>
     <relativePath>..</relativePath>
   </parent>

diff --git a/src/it/check-multi-filter-dups/module2/pom.xml b/src/it/check-multi-filter-dups/module2/pom.xml
@@ -22,7 +22,7 @@
   <modelVersion>4.0.0</modelVersion>
   <parent>
     <groupId>spotbugs-maven-plugin.it</groupId>
-    <artifactId>check-multi-parent-relative-path</artifactId>
+    <artifactId>check-multi-filter-dups</artifactId>
     <version>testing</version>
     <relativePath>..</relativePath>
   </parent>

diff --git a/src/it/check-multi-filter-dups/pom.xml b/src/it/check-multi-filter-dups/pom.xml
@@ -25,8 +25,8 @@
     <version>testing</version>
     <relativePath>../common.xml</relativePath>
   </parent>
-  <artifactId>check-multi-parent-relative-path</artifactId>
-  <name>check-multi-parent-relative-path</name>
+  <artifactId>check-multi-filter-dups</artifactId>
+  <name>check-multi-filter-dups</name>
   <packaging>pom</packaging>
   <modules>
     <module>module1</module>

diff --git a/src/it/check-multi/modules/pom.xml b/src/it/check-multi/modules/pom.xml
@@ -22,7 +22,7 @@
   <modelVersion>4.0.0</modelVersion>
   <parent>
     <groupId>spotbugs-maven-plugin.it</groupId>
-    <artifactId>multi</artifactId>
+    <artifactId>check-multi</artifactId>
     <version>testing</version>
     <relativePath>../pom.xml</relativePath>
   </parent>

diff --git a/src/it/check-multi/pom.xml b/src/it/check-multi/pom.xml
@@ -25,8 +25,8 @@
     <version>testing</version>
     <relativePath>../common.xml</relativePath>
   </parent>
-  <artifactId>multi</artifactId>
-  <name>multi</name>
+  <artifactId>check-multi</artifactId>
+  <name>check-multi</name>
   <packaging>pom</packaging>
   <modules>
     <module>modules</module>

diff --git a/src/it/check-nofail/pom.xml b/src/it/check-nofail/pom.xml
@@ -26,8 +26,8 @@
     <version>testing</version>
     <relativePath>../common.xml</relativePath>
   </parent>
-  <artifactId>check</artifactId>
-  <name>check</name>
+  <artifactId>check-nofail</artifactId>
+  <name>check-nofail</name>
   <packaging>jar</packaging>
   <build>
     <plugins>

diff --git a/src/it/encoding-utf8/pom.xml b/src/it/encoding-utf8/pom.xml
@@ -26,7 +26,7 @@
     <version>testing</version>
     <relativePath>../common.xml</relativePath>
   </parent>
-  <artifactId>basic-1</artifactId>
+  <artifactId>encoding-utf8</artifactId>
   <name>encoding-utf8</name>
   <packaging>jar</packaging>
   <properties>

diff --git a/src/it/exclude-multi-list/pom.xml b/src/it/exclude-multi-list/pom.xml
@@ -26,8 +26,8 @@
     <version>testing</version>
     <relativePath>../common.xml</relativePath>
   </parent>
-  <artifactId>excludeFile-multi-list</artifactId>
-  <name>excludeFile-multi-list</name>
+  <artifactId>exclude-multi-list</artifactId>
+  <name>exclude-multi-list</name>
   <packaging>jar</packaging>
   <build>
     <extensions>

diff --git a/src/it/exclude-multi/pom.xml b/src/it/exclude-multi/pom.xml
@@ -26,8 +26,8 @@
     <version>testing</version>
     <relativePath>../common.xml</relativePath>
   </parent>
-  <artifactId>excludeFile-multi</artifactId>
-  <name>excludeFile-multi</name>
+  <artifactId>exclude-multi</artifactId>
+  <name>exclude-multi</name>
   <packaging>jar</packaging>
   <build>
     <extensions>

diff --git a/src/it/exclude/pom.xml b/src/it/exclude/pom.xml
@@ -26,8 +26,8 @@
     <version>testing</version>
     <relativePath>../common.xml</relativePath>
   </parent>
-  <artifactId>excludeFile</artifactId>
-  <name>excludeFile</name>
+  <artifactId>exclude</artifactId>
+  <name>exclude</name>
   <packaging>jar</packaging>
   <build>
     <extensions>

diff --git a/src/it/excludeBugsFile/pom.xml b/src/it/excludeBugsFile/pom.xml
@@ -27,7 +27,7 @@
     <relativePath>../common.xml</relativePath>
   </parent>
   <artifactId>excludeBugsFiles</artifactId>
-  <name>excludeBugsFiless</name>
+  <name>excludeBugsFiles</name>
   <packaging>jar</packaging>
   <build>
     <plugins>

diff --git a/src/it/html-report/pom.xml b/src/it/html-report/pom.xml
@@ -26,8 +26,8 @@
     <version>testing</version>
     <relativePath>../common.xml</relativePath>
   </parent>
-  <artifactId>check</artifactId>
-  <name>check</name>
+  <artifactId>html-report</artifactId>
+  <name>html-report</name>
   <packaging>jar</packaging>
   <build>
     <plugins>

diff --git a/src/it/include-multi-list/pom.xml b/src/it/include-multi-list/pom.xml
@@ -26,8 +26,8 @@
     <version>testing</version>
     <relativePath>../common.xml</relativePath>
   </parent>
-  <artifactId>includeFile-multi-list</artifactId>
-  <name>includeFile-multi-list</name>
+  <artifactId>include-multi-list</artifactId>
+  <name>include-multi-list</name>
   <packaging>jar</packaging>
   <build>
     <extensions>

diff --git a/src/it/include-multi/pom.xml b/src/it/include-multi/pom.xml
@@ -26,8 +26,8 @@
     <version>testing</version>
     <relativePath>../common.xml</relativePath>
   </parent>
-  <artifactId>includeFile-multi</artifactId>
-  <name>includeFile-multi</name>
+  <artifactId>include-multi</artifactId>
+  <name>include-multi</name>
   <packaging>jar</packaging>
   <build>
     <extensions>

diff --git a/src/it/include/pom.xml b/src/it/include/pom.xml
@@ -26,8 +26,8 @@
     <version>testing</version>
     <relativePath>../common.xml</relativePath>
   </parent>
-  <artifactId>includeFile</artifactId>
-  <name>includeFile</name>
+  <artifactId>include</artifactId>
+  <name>include</name>
   <packaging>jar</packaging>
   <build>
     <extensions>

diff --git a/src/it/verify-clean/pom.xml b/src/it/verify-clean/pom.xml
@@ -26,8 +26,8 @@
     <version>testing</version>
     <relativePath>../common.xml</relativePath>
   </parent>
-  <artifactId>check</artifactId>
-  <name>check</name>
+  <artifactId>verify-clean</artifactId>
+  <name>verify-clean</name>
   <packaging>jar</packaging>
   <build>
     <plugins>

diff --git a/src/it/verify-fail/pom.xml b/src/it/verify-fail/pom.xml
@@ -26,8 +26,8 @@
     <version>testing</version>
     <relativePath>../common.xml</relativePath>
   </parent>
-  <artifactId>check</artifactId>
-  <name>check</name>
+  <artifactId>verify-fail</artifactId>
+  <name>verify-fail</name>
   <packaging>jar</packaging>
   <build>
     <plugins>

diff --git a/src/it/verify/pom.xml b/src/it/verify/pom.xml
@@ -26,8 +26,8 @@
     <version>testing</version>
     <relativePath>../common.xml</relativePath>
   </parent>
-  <artifactId>check</artifactId>
-  <name>check</name>
+  <artifactId>verify</artifactId>
+  <name>verify</name>
   <packaging>jar</packaging>
   <build>
     <plugins>