Some missing options in SnowflakeIO #5550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustedBones
reviewed
Jan 23, 2025
| @@ -186,7 +186,7 @@ final case class SnowflakeTable[T](connectionOptions: SnowflakeConnectionOptions | |||
| .read[T]() | |||
| .fromTable(table) | |||
| .withDataSourceConfiguration(dataSourceConfiguration(connectionOptions)) | |||
| .withStorageIntegrationName(params.storageIntegrationName) | |||
| .pipe(r => Option(params.storageIntegrationName).fold(r)(r.withStorageIntegrationName)) | |||
There was a problem hiding this comment.
isn't this a required parameter on read ?
There was a problem hiding this comment.
At one point I got an NPE on this one because unset then null, but can't find back how I managed to do that...
There was a problem hiding this comment.
Makes no difference, removing.
| @@ -210,6 +210,7 @@ final case class SnowflakeTable[T](connectionOptions: SnowflakeConnectionOptions | |||
| .pipe(w => Option(params.flushTimeLimit).fold(w)(w.withFlushTimeLimit)) | |||
| .pipe(w => Option(params.quotationMark).fold(w)(w.withQuotationMark)) | |||
| .pipe(w => Option(params.storageIntegrationName).fold(w)(w.withStorageIntegrationName)) | |||
| .pipe(w => Option(params.tableSchema).fold(w)(w.withTableSchema)) | |||
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5550 +/- ##
==========================================
- Coverage 61.31% 61.28% -0.03%
==========================================
Files 314 314
Lines 11249 11250 +1
Branches 770 793 +23
==========================================
- Hits 6897 6895 -2
- Misses 4352 4355 +3 ☔ View full report in Codecov by Sentry. |
turb
force-pushed
the
snowflake-write-opts
branch
from
0723400 to
ae81e3d
Compare
RustedBones
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.