Add support for multiple target variants, improve SDK path handling #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockbruno
force-pushed
the
rochab/multi-variants
branch
from
2451c99 to
0fce58b
Compare
rockbruno
force-pushed
the
rochab/multi-variants
branch
from
0fce58b to
3fc77fa
Compare
rockbruno
changed the title
rockbruno
force-pushed
the
rochab/multi-variants
branch
from
a2dc1aa to
8580e98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lifts the restriction where a target cannot exist under multiple configurations. It will now process all variants.
There is still a restriction for multiple top-level apps though. Will fix that later on.
This also simplifies the sdk processing logic to now also enable device builds, as well as flipping a couple of log levels to make the logs less noisy.