Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Provide a brief summary of the changes in this PR and link to the relevant issue(s) if applicable.
There was a circular dependency with using the importer classes, so the logic for uploading the user file and getting the different JSON keys is in the
UserAnalyticsclass now. This also makes it so the user file upload logic can be removed from theMatchAnalyticsfile, which it should never have been in in the first place.Current Behavior
Please describe the current behavior that you are modifying.
The user upload was being handled in the
MatchAnalyticsclass, which required an awkward import forMatchAnalyticson theUserPage.New Behavior
Please describe the behavior or changes that are being added by this PR.
The
UserAnalyticsclass handles the user file import now, and the logic for getting the right keys foraccountsanddevicesis much simpler and cleaner.The lat and log coordinate data has been commented out for now since it wasn't working super well before and needs a whole new solution.
Does this new change introduce a breaking change?
If this introduces a breaking change:
Other Information
Any other information that is useful to note: visual changes, dependency changes, etc.