Skip to content

Comments

User importer#37

Merged
spottseng merged 2 commits intomainfrom
user-importer
Feb 18, 2025
Merged

User importer#37
spottseng merged 2 commits intomainfrom
user-importer

Conversation

@spottseng
Copy link
Owner

Summary

Provide a brief summary of the changes in this PR and link to the relevant issue(s) if applicable.
There was a circular dependency with using the importer classes, so the logic for uploading the user file and getting the different JSON keys is in the UserAnalytics class now. This also makes it so the user file upload logic can be removed from the MatchAnalytics file, which it should never have been in in the first place.

Current Behavior

Please describe the current behavior that you are modifying.
The user upload was being handled in the MatchAnalytics class, which required an awkward import for MatchAnalytics on the UserPage.

New Behavior

Please describe the behavior or changes that are being added by this PR.
The UserAnalytics class handles the user file import now, and the logic for getting the right keys for accounts and devices is much simpler and cleaner.

The lat and log coordinate data has been commented out for now since it wasn't working super well before and needs a whole new solution.

Does this new change introduce a breaking change?

  • Yes
  • No

If this introduces a breaking change:

  1. Describe the impact on the application below.
  2. Update the BREAKING.md file with the breaking change.
  3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
  4. Create a ticket on the GitHub Project board to address the issue later.

Other Information

Any other information that is useful to note: visual changes, dependency changes, etc.

@spottseng spottseng merged commit dfdf3eb into main Feb 18, 2025
1 check passed
@spottseng spottseng deleted the user-importer branch February 18, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant