Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize: PHP81 with rector #270

Merged
merged 3 commits into from
Dec 7, 2024

Conversation

kohlerdominik
Copy link
Contributor

Inspired by #269, I took a dive whether there's some more code to modernize. I realized, that you already added Rector in #265, but it seems like either the 8.1 preset was updated since then, or it was not fully applied?

This PR

  • simplifies and improves the rector config
    • importNames and importShortClasses config was kept
    • removeUnusedImports was added
    • withPhpSets uses the Composer config by default, so no explicit declaring of the set is required
  • makes Output-examples more consistent and fixes, that Rector wants to remove the duplicate Sprain\SwissQrBill as QrBill import
  • applies Rector for PHP81 set:

@sprain
Copy link
Owner

sprain commented Dec 7, 2024

Thank you! 🤩

@sprain sprain merged commit 5881f1c into sprain:master Dec 7, 2024
9 checks passed
@sprain sprain mentioned this pull request Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants