Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: PHPUnit 10 #271

Merged
merged 8 commits into from
Feb 12, 2025
Merged

Upgrade: PHPUnit 10 #271

merged 8 commits into from
Feb 12, 2025

Conversation

kohlerdominik
Copy link
Contributor

@kohlerdominik kohlerdominik commented Dec 6, 2024

Upgrade to PHPUnit10

Notes:

  • Updating BypassFinals was quite a hassle. In the end I got it working by using nunomaduro/mock-final-classes instead of the method providing by dg/bypass-finals using the PHPUnit extension. It seems like, that with the extensions some files are not catched by the stream-wrapper and therefore get not stripped of the final keyword... Might be worth to try to use the extension in PHPUnit11 again.
  • The new class QrBillTestDataRepository is an extraction of the former TestQrBillCreatorTrait. Method-names feel dirty, but because there is some magic involved in building a QR-Bill by passing string matching methods, refactoring the whole thing feels out of scope for this upgrade. I suggest to implement a QrBillBuilder instead (with the same functionality but clearer syntax), but I can't invest time into that for now.

Todos:

@kohlerdominik kohlerdominik force-pushed the upgrade/phpunit10 branch 2 times, most recently from b1ef1a1 to b609bdc Compare December 7, 2024 12:02
@kohlerdominik kohlerdominik marked this pull request as ready for review December 7, 2024 12:44
@kohlerdominik
Copy link
Contributor Author

@sprain have you seen that I finished this draft? :)

@sprain
Copy link
Owner

sprain commented Feb 12, 2025

… I just rediscovered this PR that I had forgotten about. Thanks for the patience! I will look into it.

@sprain sprain merged commit 9dbba5e into sprain:master Feb 12, 2025
9 checks passed
@sprain
Copy link
Owner

sprain commented Feb 12, 2025

Great work, thanks a lot 🙏

@kohlerdominik
Copy link
Contributor Author

@sprain you actually want to keep the version constraint on "dg/bypass-finals": "^1.8", because otherwise it will fall back to v1.1 in prefer-lowest mode. ff9940b

Source: already tried to remove it :)

@sprain
Copy link
Owner

sprain commented Feb 12, 2025

@kohlerdominik Thanks, I just realized this thanks to failing tests 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants