Hotfix/skip details #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
combinatorist
commented
Sep 17, 2025
Comment on lines
+16
to
+17
| POST_DETAILS_TO_CTFG: bool = "TRUE".startswith( | ||
| os.getenv("POST_DETAILS_TO_CTFG", "False").upper() |
Collaborator
Author
There was a problem hiding this comment.
Main change: this cuts down on unnecessary records
src/config.py
Outdated
Comment on lines
40
to
41
| WIKIDATA_MAX_LISTINGS_TO_SEARCH: int = int( | ||
| os.getenv("WIKIDATA_MAX_LISTINGS_TO_SEARCH", 5) |
Collaborator
Author
There was a problem hiding this comment.
Make this externally configurable.
| # WikidataItem.recursive_save(wiki_items) | ||
| if wiki_items: | ||
| log("Example item") | ||
| pprint(wiki_items[0].to_record()) |
Collaborator
Author
There was a problem hiding this comment.
better logging (know how many before start and only show example if available)
combinatorist
commented
Sep 17, 2025
| requires-python = "<4.0,>=3.13" | ||
| dependencies = [ | ||
| "wikibaseintegrator @ git+https://github.com/LeMyst/WikibaseIntegrator.git@301067883ddce0bca31fdd54973c3d6c8cbbcb7d", | ||
| "wikibaseintegrator @ git+https://github.com/combinatorist/WikibaseIntegrator.git@feature/search_entities-exact-max_results", |
Collaborator
Author
There was a problem hiding this comment.
Comment on lines
+40
to
+42
| def getEnvInt(name: str, default: int) -> int: | ||
| raw = os.getenv("WIKIDATA_MAX_RESULTS_PER_SEARCH") | ||
| return int(raw) if raw else default |
Collaborator
Author
There was a problem hiding this comment.
safer int retrieval
Comment on lines
+21
to
+23
| sample(matchable_items, max_attempts) | ||
| if max_attempts and max_attempts < len(matchable_items) | ||
| else matchable_items |
Collaborator
Author
There was a problem hiding this comment.
safer sampling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.