This repository has been archived by the owner on Feb 27, 2020. It is now read-only.
Enhancements for supporting multiple identity providers, and a few other changes. #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses several issues reported against the DSL and adds several new features to it.
Added the ability to change the signing algorithm from the default SHA1 (Resolves Add support for customizing the authentication provider, signature algorithm and maxAuthenticationAge #54 )
Added The ability to change the authentication provider that gets used to validate the SAML assertion. This is useful when we want to trust the IDP for authentication, but not authorization. (Resolves Add support for customizing the authentication provider, signature algorithm and maxAuthenticationAge #54)
Added a way to provide a custom AuthenticationSuccessHandler and AuthenticationFailureHandler to be used when SAML logins succeed or fail. This might address Issue Customize success and failure login handler #50. This is also discussed in Issue Improvements: Fix several customization Issues #52, and Pull Request Provide several customization #53. I'm not sure how it was implemented in Provide several customization #53, so care would need to be taken before merging it in.
Added support for multiple Identitiy Providers. Each time you call
identityProvider
(), it adds a new one to the list. (Resolves Add support for multiple IdentityProviders #55)Added a way to configure SAML via a delegateConfig method. This is useful for doing things like reading all the SAML metadata from a directory and creating an IDP for each file. This is also part of Issue Add support for multiple IdentityProviders #55, which also has an example of how to use the delegate.
I don't have good unit tests for this code, but I have used all of my changes in our application, and they seem to work, and the changes don't break any of the existing unit tests.