clean-up for issue 1592 #1782
Merged
clean-up for issue 1592 #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
wind57
commented
Nov 4, 2024
| @@ -1,6 +1,9 @@ | |||
| logging: | |||
| level: | |||
| root: DEBUG | |||
| org: | |||
There was a problem hiding this comment.
change logger for less logs, otherwise its way too many of them and its complicated to understand what is going on
wind57
commented
Nov 4, 2024
| // Clean up any open connections from the KubernetesClient when the context is closed | ||
| BeanFactoryUtils.beansOfTypeIncludingAncestors(event.getApplicationContext(), KubernetesClient.class).values() | ||
| .forEach(Client::close); | ||
| // Clean up any open connections from the KubernetesClient when the context is |
There was a problem hiding this comment.
formatting, nothing else
wind57
commented
Nov 4, 2024
| @@ -141,25 +141,25 @@ else if (propertySource instanceof CompositePropertySource source) { | |||
| return result; | |||
| } | |||
|
|
|||
| static boolean changed(List<? extends MapPropertySource> left, List<? extends MapPropertySource> right) { | |||
There was a problem hiding this comment.
only renames of variables, nothing else
Signed-off-by: wind57 <eugen.rabii@gmail.com>
|
@ryanjbaxter this is ready to be looked at. It does some clean-up in preparation of the real fix. thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.